From: Greg KH <gregkh@suse.de>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Pekka Enberg <penberg@kernel.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: linux-next: Tree for March 1 (staging/winbond)
Date: Tue, 1 Mar 2011 15:07:07 -0500 [thread overview]
Message-ID: <20110301200707.GA12492@suse.de> (raw)
In-Reply-To: <20110301113930.69d7d992.randy.dunlap@oracle.com>
On Tue, Mar 01, 2011 at 11:39:30AM -0800, Randy Dunlap wrote:
> On Tue, 1 Mar 2011 21:35:59 +0200 Pekka Enberg wrote:
>
> > On Tue, Mar 1, 2011 at 9:19 PM, Randy Dunlap <randy.dunlap@oracle.com> wrote:
> > > On Tue, 1 Mar 2011 21:10:23 +0200 Pekka Enberg wrote:
> > >
> > >> On Tue, Mar 1, 2011 at 8:49 PM, Randy Dunlap <randy.dunlap@oracle.com> wrote:
> > >> > On Tue, 1 Mar 2011 18:11:19 +1100 Stephen Rothwell wrote:
> > >> >
> > >> >> Hi all,
> > >> >>
> > >> >> Changes since 20110228:
> > >> >
> > >> >
> > >> > commit ddee7e28e7d5e4ba2b8537c6a59b035745c250bb
> > >> > Author: Pekka Enberg <penberg@kernel.org>
> > >> > Date: Sun Nov 28 23:00:01 2010 +0200
> > >> > Staging: w35und: Remove empty sysdef.h header
> > >> >
> > >> >
> > >> > This header should not have been empty, since in
> > >> >
> > >> > commit 412dc7f368bf10a8049a8a4c41abbfd0108742e7
> > >> > Author: Randy Dunlap <randy.dunlap@oracle.com>
> > >> > Date: Fri Nov 19 09:30:18 2010 -0800
> > >> > staging: fix winbond build, needs delay.h
> > >> >
> > >> > I added delay.h to it. And now we have the same build
> > >> > errors that I fixed last November:
> > >> >
> > >> > drivers/staging/winbond/phy_calibration.c:986: error: implicit declaration of function 'msleep'
> > >> > drivers/staging/winbond/phy_calibration.c:1555: error: implicit declaration of function 'udelay'
> > >> > drivers/staging/winbond/reg.c:893: error: implicit declaration of function 'msleep'
> > >> > drivers/staging/winbond/reg.c:1169: error: implicit declaration of function 'udelay'
> > >>
> > >> Strange. I didn't see the problem. We should add delay.h to
> > >> phy_calibration.c and reg.c instead. Care to make a patch?
> > >> --
> > >
> > > No thanks, I'll let the staging people do that.
> >
> > Hmm, commit cecf826df8648c843ea8db63b1f82c154a74db36 ("staging:
> > winbond: needs <linux/delay.h> for msleep and friends") should fix it.
> > Isn't it in linux-next yet?
It should be in there tomorrow, the linux-next pull-time happened after
I pushed out my trees.
thanks,
greg k-h
next prev parent reply other threads:[~2011-03-01 20:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-01 7:11 linux-next: Tree for March 1 Stephen Rothwell
2011-03-01 18:49 ` linux-next: Tree for March 1 (staging/winbond) Randy Dunlap
2011-03-01 19:10 ` Pekka Enberg
2011-03-01 19:19 ` Randy Dunlap
2011-03-01 19:35 ` Pekka Enberg
2011-03-01 19:39 ` Randy Dunlap
2011-03-01 20:05 ` Pekka Enberg
2011-03-01 20:07 ` Greg KH [this message]
2011-03-02 0:29 ` [PATCH -next] staging/brcm80211: fix printk format warnings Randy Dunlap
2011-03-02 14:07 ` Roland Vossen
2011-03-02 21:02 ` Greg KH
2011-03-02 21:05 ` Greg KH
2011-03-02 23:36 ` Stephen Rothwell
2011-03-03 7:20 ` Stanislav Fomichev
2011-03-03 16:08 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110301200707.GA12492@suse.de \
--to=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=penberg@kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).