Re: linux-next: build failure after merge of the final tree (jdelvare-hwmon tree related)

Jean Delvare
2011-03-15T09:32:45Z

On Tue, 15 Mar 2011 09:40:41 +0100, Hans de Goede wrote:
> Hi,
>
> On 03/15/2011 09:24 AM, Stephen Rothwell wrote:
> > Hi all,
> >
> > After merging the final tree, today's linux-next build (powerpc
> > allyesconfig) failed like this:
> >
> > drivers/hwmon/sch5627.c: In function 'sch5627_read_virtual_reg':
> > drivers/hwmon/sch5627.c:179: error: implicit declaration of function 'msleep'
> >
> > Caused by commit 19803daeb145 ("hwmon: New driver for SMSC SCH5627").
> > See Rule 1 in Documentation/SubmitChecklist.
> >
> > I have reverted that commit for today.
>
> The attached patch should fix this, Jean can you please add this to your
> tree? Note feel free to merge it into the initial patch adding the sch5627 driver
> if you prefer.

Thanks for the fix, I've merged it in the original patch (to preserve
bisectability) and pushed it for next linux-next.

Stephen, sorry for the inconvenience, both Hans and myself build-tested
the new code on an architecture where <linux/delay.h> gets included
implicitly, so we didn't notice it was missing.

--
Jean Delvare