linux-next: build warning in Linus' tree

linux-next: build warning in Linus' tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 545 bytes --]

Hi all,

After merging the Linus' tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

drivers/infiniband/core/addr.c: In function 'addr4_resolve':
drivers/infiniband/core/addr.c:188: warning: 'ret' may be used uninitialized in this function

I didn't notice this one before, sorry.

I don't know what introduced it, but the third if statement in the
function will make us use "ret" uninitialised.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

[PATCH] rdma/addr: Initialize ret to fix build warning

[Hefty, Sean]

Commit b23dd4fe42b455af5c6e20966b7d6959fa8352ea (ipv4: Make output
route lookup return rtable directly) resulted in leaving
ret uninitialized, where it may later be returned.

Signed-off-by: Sean Hefty <sean.hefty@intel.com>
---
I didn't actually test this, but it looks correct.

 drivers/infiniband/core/addr.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/infiniband/core/addr.c b/drivers/infiniband/core/addr.c
index e0ef5fd..4ffc224 100644
--- a/drivers/infiniband/core/addr.c
+++ b/drivers/infiniband/core/addr.c
@@ -204,7 +204,7 @@ static int addr4_resolve(struct sockaddr_in *src_in,
 
 	/* If the device does ARP internally, return 'done' */
 	if (rt->dst.dev->flags & IFF_NOARP) {
-		rdma_copy_addr(addr, rt->dst.dev, NULL);
+		ret = rdma_copy_addr(addr, rt->dst.dev, NULL);
 		goto put;
 	}
 

Re: [PATCH] rdma/addr: Initialize ret to fix build warning

[Roland Dreier]

On Thu, Mar 17, 2011 at 4:35 PM, Hefty, Sean <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> wrote:
> Commit b23dd4fe42b455af5c6e20966b7d6959fa8352ea (ipv4: Make output
> route lookup return rtable directly) resulted in leaving
> ret uninitialized, where it may later be returned.

Looks good to me, I'll merge this.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] rdma/addr: Initialize ret to fix build warning

[David Miller]

From: Roland Dreier <roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Date: Thu, 17 Mar 2011 16:56:27 -0700

> On Thu, Mar 17, 2011 at 4:35 PM, Hefty, Sean <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> wrote:
>> Commit b23dd4fe42b455af5c6e20966b7d6959fa8352ea (ipv4: Make output
>> route lookup return rtable directly) resulted in leaving
>> ret uninitialized, where it may later be returned.
> 
> Looks good to me, I'll merge this.

Thanks Roland.

Acked-by: David S. Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: linux-next: build warning in Linus' tree

[David Miller]

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Fri, 18 Mar 2011 10:04:18 +1100

> Hi all,
> 
> After merging the Linus' tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
> 
> drivers/infiniband/core/addr.c: In function 'addr4_resolve':
> drivers/infiniband/core/addr.c:188: warning: 'ret' may be used uninitialized in this function
> 
> I didn't notice this one before, sorry.
> 
> I don't know what introduced it, but the third if statement in the
> function will make us use "ret" uninitialised.

It was the ipv4 route lookup interface changes.

Roland has received a fix already, and will merge it via the infiniband
tree.