From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>,
Shyam_Iyer@Dell.com, mjg59@srcf.ucam.org, Narendra_K@Dell.com,
viro@zeniv.linux.org.uk, sfr@canb.auug.org.au,
linux-kernel@vger.kernel.org, linux-next@vger.kernel.org,
Matt_Domsch@Dell.com, Charles_Rose@Dell.com,
Jordan_Hargrave@Dell.com
Subject: Re: [PATCH] pci-label: Fix build failure when CONFIG_NLS is set to 'm' by allmodconfig
Date: Tue, 29 Mar 2011 09:55:09 -0700 [thread overview]
Message-ID: <20110329095509.12d6024d@jbarnes-desktop> (raw)
In-Reply-To: <20110329094557.17cd57a1.randy.dunlap@oracle.com>
On Tue, 29 Mar 2011 09:45:57 -0700
Randy Dunlap <randy.dunlap@oracle.com> wrote:
> On Wed, 30 Mar 2011 01:39:46 +0900 OGAWA Hirofumi wrote:
>
> > Randy Dunlap <randy.dunlap@oracle.com> writes:
> >
> > >> config PCI_LABEL
> > >> bool
> > >> select NLS
> > >> depends on (DMI || ACPI)
> > >
> > > What sets/enables it then?
> > > or did you mean:
> > > def_bool y
> > > and in that case, should it be a user-visible & user-changeable kconfig option?
> >
> > Whoops, last line was missed by copy&paste. It meant
> >
> > config PCI_LABEL
> > bool
> > select NLS
> > depends on (DMI || ACPI)
> > default y
> >
> > And no, it shouldn't be user-changeable (it would be better to
> > invisible in .config. At make *config, already invisible.). Because
> > PCI_LABEL is not user config and not used in Makefile.
> >
> > And yeah, if you like def_bool
> >
> > config PCI_LABEL
> > def_bool y if (DMI || ACPI)
> > select NLS
> >
> > I guess it would work (it should be just syntax sugar and equivalent).
>
>
> This patch seems to work for me. Thanks.
>
> ---
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> Create a kconfig option symbol for PCI_LABEL and enable it
> when DMI || ACPI are enabled.
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> ---
> drivers/pci/Kconfig | 4 +++-
> drivers/pci/Makefile | 4 ++--
> 2 files changed, 5 insertions(+), 3 deletions(-)
>
> --- linux-next-20110328.orig/drivers/pci/Kconfig
> +++ linux-next-20110328/drivers/pci/Kconfig
> @@ -88,4 +88,6 @@ config PCI_IOAPIC
> depends on HOTPLUG
> default y
>
> -select NLS if (DMI || ACPI)
> +config PCI_LABEL
> + def_bool y if (DMI || ACPI)
> + select NLS
> --- linux-next-20110328.orig/drivers/pci/Makefile
> +++ linux-next-20110328/drivers/pci/Makefile
> @@ -56,10 +56,10 @@ obj-$(CONFIG_TILE) += setup-bus.o setup-
> # ACPI Related PCI FW Functions
> # ACPI _DSM provided firmware instance and string name
> #
> -obj-$(CONFIG_ACPI) += pci-acpi.o pci-label.o
> +obj-$(CONFIG_ACPI) += pci-acpi.o
>
> # SMBIOS provided firmware instance and labels
> -obj-$(CONFIG_DMI) += pci-label.o
> +obj-$(CONFIG_PCI_LABEL) += pci-label.o
>
> # Cardbus & CompactPCI use setup-bus
> obj-$(CONFIG_HOTPLUG) += setup-bus.o
>
Applied to my fixes branch, thanks Randy & Hirofumi-san.
--
Jesse Barnes, Intel Open Source Technology Center
next prev parent reply other threads:[~2011-03-29 16:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-23 12:54 [PATCH] Fix build failure when CONFIG_NLS is set to 'm' by allmodconfig Narendra_K
2011-02-23 13:17 ` Matthew Garrett
2011-03-04 18:15 ` Jesse Barnes
2011-03-28 15:02 ` Randy Dunlap
2011-03-28 16:17 ` Jesse Barnes
2011-03-28 19:14 ` Shyam_Iyer
2011-03-28 20:22 ` Randy Dunlap
2011-03-29 1:55 ` OGAWA Hirofumi
2011-03-29 16:18 ` Randy Dunlap
2011-03-29 16:23 ` Jesse Barnes
2011-03-29 16:39 ` OGAWA Hirofumi
2011-03-29 16:45 ` [PATCH] pci-label: " Randy Dunlap
2011-03-29 16:55 ` Jesse Barnes [this message]
2011-03-31 9:27 ` Narendra_K
2011-04-19 6:06 ` [PATCH] " Ingo Molnar
2011-04-19 8:43 ` Narendra_K
2011-04-19 16:25 ` Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110329095509.12d6024d@jbarnes-desktop \
--to=jbarnes@virtuousgeek.org \
--cc=Charles_Rose@Dell.com \
--cc=Jordan_Hargrave@Dell.com \
--cc=Matt_Domsch@Dell.com \
--cc=Narendra_K@Dell.com \
--cc=Shyam_Iyer@Dell.com \
--cc=hirofumi@mail.parknet.co.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=randy.dunlap@oracle.com \
--cc=sfr@canb.auug.org.au \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).