From: Jean Delvare <khali@linux-fr.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>,
Randy Dunlap <randy.dunlap@oracle.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Ben Dooks <ben-linux@fluff.org>
Cc: Baruch Siach <baruch@tkos.co.il>,
linux-i2c@vger.kernel.org, linux-next@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next reresend] i2c: designware-pcidrv depends on PCI
Date: Tue, 12 Apr 2011 11:47:22 +0200 [thread overview]
Message-ID: <20110412114722.0f2e67d6@endymion.delvare> (raw)
In-Reply-To: <BANLkTikX_rG+6Eg4owary1YRGRG8NzyrGQ@mail.gmail.com>
Geert, Randy,
On Sat, 9 Apr 2011 13:34:49 +0200, Geert Uytterhoeven wrote:
> On Fri, Apr 8, 2011 at 17:32, Randy Dunlap <randy.dunlap@oracle.com> wrote:
> > From: Randy Dunlap <randy.dunlap@oracle.com>
> >
> > i2c-designware-pcidrv is a PCI driver and should depend on PCI.
> > Fixes these build errors:
> >
> > drivers/i2c/busses/i2c-designware-pcidrv.c:256: error: implicit declaration of function 'pci_request_region'
> > drivers/i2c/busses/i2c-designware-pcidrv.c:338: error: implicit declaration of function 'pci_release_region'
> >
> > Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> > Cc: Baruch Siach <baruch@tkos.co.il>
> > ---
> > drivers/i2c/busses/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > Does anybody merge i2c patches???
>
> Yes please, it's been there since Mar 17, reported several times, and probably
> masking other build failures.
This bug only exists in linux-next, as the code in question wasn't
merged in Linus's tree yet. It is drawn into linux-next from Ben
Dooks's next-i2c branch:
http://git.fluff.org/gitweb?p=bjdooks/linux.git;a=shortlog;h=refs/heads/next-i2c
This is where it has to be fixed, so only Ben can do it. Ben, please?
Meanwhile, it should be possible to apply a hot fix to linux-next
directly, Stephen does it pretty often. Stephen, could you please apply
this fix temporarily until Ben wakes up and applies it to his tree?
> > --- linux-next-20110316.orig/drivers/i2c/busses/Kconfig
> > +++ linux-next-20110316/drivers/i2c/busses/Kconfig
> > @@ -359,6 +359,7 @@ config I2C_DESIGNWARE_PLATFORM
> >
> > config I2C_DESIGNWARE_PCI
> > tristate "Synopsys DesignWare PCI"
> > + depends on PCI
> > help
> > If you say yes to this option, support will be included for the
> > Synopsys DesignWare I2C adapter. Only master mode is supported.
--
Jean Delvare
next prev parent reply other threads:[~2011-04-12 9:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-08 15:32 [PATCH -next reresend] i2c: designware-pcidrv depends on PCI Randy Dunlap
2011-04-09 11:34 ` Geert Uytterhoeven
2011-04-12 9:47 ` Jean Delvare [this message]
2011-04-12 15:48 ` Randy Dunlap
[not found] ` <20110412114722.0f2e67d6-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2011-04-12 22:38 ` Stephen Rothwell
2011-04-19 21:45 ` Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110412114722.0f2e67d6@endymion.delvare \
--to=khali@linux-fr.org \
--cc=baruch@tkos.co.il \
--cc=ben-linux@fluff.org \
--cc=geert@linux-m68k.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).