From: Dave Jones <davej@redhat.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: linux-next: build warning after merge of the cpufreq tree
Date: Tue, 26 Apr 2011 21:32:17 -0400 [thread overview]
Message-ID: <20110427013217.GA30804@redhat.com> (raw)
In-Reply-To: <20110427111024.eb26b6f5.sfr@canb.auug.org.au>
On Wed, Apr 27, 2011 at 11:10:24AM +1000, Stephen Rothwell wrote:
> Hi Dave,
>
> After merging the cpufreq tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
>
> drivers/cpufreq/Kconfig:67:warning: choice value used outside its choice group
> drivers/cpufreq/Kconfig:75:warning: choice value used outside its choice group
> drivers/cpufreq/Kconfig:84:warning: choice value used outside its choice group
> drivers/cpufreq/Kconfig:93:warning: choice value used outside its choice group
> drivers/cpufreq/Kconfig:105:warning: choice value used outside its choice group
>
> I am not sure what has caused this. The only change in the cpufreq tree
> to that file is commit e002ba3328a2 ("[CPUFREQ] Move x86 cpufreq drivers
> to drivers/cpufreq/") which rearranged a few things but nothing obvious.
As the commit message suggests, per-arch cpufreq drivers are moving to drivers/cpufreq/
So far, I've only moved the x86 ones. As a side-effect of this, the
source "drivers/cpufreq/Kconfig" is no longer a per-arch thing, as it now gets
included from kernel/power/Kconfig.
I suspect the warnings are happening because on the unconverted archs, drivers/cpufreq/Kconfig
is now getting included twice. If you kill the 'source' line in kernel/power/Kconfig,
does this make things go back to normal ? (Check that cpufreq still shows up in
the resulting config afterwards)
If so, I'll make that change after all archs have moved their drivers.
Dave
next prev parent reply other threads:[~2011-04-27 1:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-27 1:10 linux-next: build warning after merge of the cpufreq tree Stephen Rothwell
2011-04-27 1:32 ` Dave Jones [this message]
2011-04-27 1:54 ` Stephen Rothwell
2011-04-27 2:41 ` Dave Jones
2011-04-29 20:12 ` Dave Jones
2011-05-02 5:06 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110427013217.GA30804@redhat.com \
--to=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).