From: Greg KH <greg@kroah.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
brudley@broadcom.com, henryp@broadcom.com, rvossen@broadcom.com,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
Linus <torvalds@linux-foundation.org>,
sparclinux@vger.kernel.org,
Linux-Arch <linux-arch@vger.kernel.org>
Subject: Re: linux-next: build failure after merge of the final tree (staging related)
Date: Wed, 15 Jun 2011 08:47:06 -0700 [thread overview]
Message-ID: <20110615154706.GA19707@kroah.com> (raw)
In-Reply-To: <BANLkTim5dYNmTMJo-Wa3LYCTi4vxPGMNeQ@mail.gmail.com>
On Wed, Jun 15, 2011 at 02:05:29PM +0200, Geert Uytterhoeven wrote:
> On Fri, Jun 10, 2011 at 08:05, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > On Thu, 9 Jun 2011 12:22:43 -0700 Greg KH <greg@kroah.com> wrote:
> >> On Thu, Jun 09, 2011 at 11:41:27AM -0700, Greg KH wrote:
> >> > > Also in several other files in drivers/staging/brcm80211/
> >> > >
> >> > > Also:
> >> > >
> >> > > drivers/staging/comedi/drivers.c: In function 'comedi_buf_alloc':
> >> > > drivers/staging/comedi/drivers.c:505:37: error: 'PAGE_KERNEL_NOCACHE' undeclared (first use in this function)
>
> I have my doubts
>
> #ifdef PAGE_KERNEL_NOCACHE
> vmap(pages, n_pages, VM_MAP, PAGE_KERNEL_NOCACHE);
> #else
> vmap(pages, n_pages, VM_MAP, PAGE_KERNEL);
> #endif
>
> is the right "fix" for this...
>
> BTW, PAGE_KERNEL_NOCACHE is defined on frv, m32r, mn10300, sh, and x86 only.
>
> Strangely, both sparc and tile have
>
> /*
> * Some hardware wants to get fixmapped without caching.
> */
> #define set_fixmap_nocache(idx, phys) \
> __set_fixmap(idx, phys, PAGE_KERNEL_NOCACHE)
>
> in their <asm/fixmap.h>, without having PAGE_KERNEL_NOCACHE...
So, what should the correct fix here be?
confused,
greg k-h
next prev parent reply other threads:[~2011-06-15 15:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-09 7:27 linux-next: build failure after merge of the final tree (staging related) Stephen Rothwell
2011-06-09 18:41 ` Greg KH
2011-06-09 19:22 ` Greg KH
2011-06-10 6:05 ` Stephen Rothwell
2011-06-10 6:09 ` Stephen Rothwell
2011-06-10 22:34 ` Greg KH
2011-06-15 4:21 ` Stephen Rothwell
2011-06-16 19:14 ` Greg KH
2011-06-23 0:35 ` Stephen Rothwell
2011-06-23 21:51 ` Greg KH
2011-06-24 0:00 ` Stephen Rothwell
2011-06-27 21:45 ` Greg KH
2011-06-28 0:16 ` Stephen Rothwell
2011-06-15 12:05 ` Geert Uytterhoeven
2011-06-15 15:47 ` Greg KH [this message]
2011-06-15 14:35 ` [PATCH] arch/tile: remove useless set_fixmap_nocache() macro Chris Metcalf
2011-06-09 19:52 ` linux-next: build failure after merge of the final tree (staging related) Henry Ptasinski
2011-06-09 20:19 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110615154706.GA19707@kroah.com \
--to=greg@kroah.com \
--cc=brudley@broadcom.com \
--cc=geert@linux-m68k.org \
--cc=henryp@broadcom.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=rvossen@broadcom.com \
--cc=sfr@canb.auug.org.au \
--cc=sparclinux@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).