From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: linux-next: build failure after merge of the final tree (staging related) Date: Wed, 15 Jun 2011 08:47:06 -0700 Message-ID: <20110615154706.GA19707@kroah.com> References: <20110609172745.dfd3a298.sfr@canb.auug.org.au> <20110609184127.GA2760@kroah.com> <20110609192243.GA3980@kroah.com> <20110610160548.529797c7.sfr@canb.auug.org.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Geert Uytterhoeven Cc: Stephen Rothwell , brudley@broadcom.com, henryp@broadcom.com, rvossen@broadcom.com, linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Linus , sparclinux@vger.kernel.org, Linux-Arch List-Id: linux-next.vger.kernel.org On Wed, Jun 15, 2011 at 02:05:29PM +0200, Geert Uytterhoeven wrote: > On Fri, Jun 10, 2011 at 08:05, Stephen Rothwell wrote: > > On Thu, 9 Jun 2011 12:22:43 -0700 Greg KH wrote: > >> On Thu, Jun 09, 2011 at 11:41:27AM -0700, Greg KH wrote: > >> > > Also in several other files in drivers/staging/brcm80211/ > >> > > > >> > > Also: > >> > > > >> > > drivers/staging/comedi/drivers.c: In function 'comedi_buf_alloc': > >> > > drivers/staging/comedi/drivers.c:505:37: error: 'PAGE_KERNEL_NOCACHE' undeclared (first use in this function) > > I have my doubts > > #ifdef PAGE_KERNEL_NOCACHE > vmap(pages, n_pages, VM_MAP, PAGE_KERNEL_NOCACHE); > #else > vmap(pages, n_pages, VM_MAP, PAGE_KERNEL); > #endif > > is the right "fix" for this... > > BTW, PAGE_KERNEL_NOCACHE is defined on frv, m32r, mn10300, sh, and x86 only. > > Strangely, both sparc and tile have > > /* > * Some hardware wants to get fixmapped without caching. > */ > #define set_fixmap_nocache(idx, phys) \ > __set_fixmap(idx, phys, PAGE_KERNEL_NOCACHE) > > in their , without having PAGE_KERNEL_NOCACHE... So, what should the correct fix here be? confused, greg k-h