From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: linux-next: build failure after merge of the final tree (staging related) Date: Thu, 23 Jun 2011 14:51:15 -0700 Message-ID: <20110623215115.GB10969@kroah.com> References: <20110609172745.dfd3a298.sfr@canb.auug.org.au> <20110609184127.GA2760@kroah.com> <20110609192243.GA3980@kroah.com> <20110610160548.529797c7.sfr@canb.auug.org.au> <20110610160938.cd01c408.sfr@canb.auug.org.au> <20110610223423.GB15868@kroah.com> <20110615142155.bd538b73.sfr@canb.auug.org.au> <20110616191448.GA10255@kroah.com> <20110623103503.cd9e7e70.sfr@canb.auug.org.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from out3.smtp.messagingengine.com ([66.111.4.27]:44270 "EHLO out3.smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933553Ab1FWVww (ORCPT ); Thu, 23 Jun 2011 17:52:52 -0400 Content-Disposition: inline In-Reply-To: <20110623103503.cd9e7e70.sfr@canb.auug.org.au> Sender: linux-next-owner@vger.kernel.org List-ID: To: Stephen Rothwell Cc: brudley@broadcom.com, henryp@broadcom.com, rvossen@broadcom.com, linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Linus On Thu, Jun 23, 2011 at 10:35:03AM +1000, Stephen Rothwell wrote: > Hi Greg, > > On Thu, 16 Jun 2011 12:14:48 -0700 Greg KH wrote: > > > > On Wed, Jun 15, 2011 at 02:21:55PM +1000, Stephen Rothwell wrote: > > > > > > On Fri, 10 Jun 2011 15:34:23 -0700 Greg KH wrote: > > > > > > > > On Fri, Jun 10, 2011 at 04:09:38PM +1000, Stephen Rothwell wrote: > > > > > > > > > > On Fri, 10 Jun 2011 16:05:48 +1000 Stephen Rothwell wrote: > > > > > > > > > > > > No, I still get these: > > > > > > > > > > > > In file included from drivers/staging/comedi/drivers/addi_apci_035.c:7:0: > > > > > > drivers/staging/comedi/drivers/addi-data/addi_common.c: In function 'i_ADDI_Attach': > > > > > > drivers/staging/comedi/drivers/addi-data/addi_common.c:2765:7: error: implicit declaration of function 'virt_to_bus' > > > > > > > > > > > > virt_to_bus is only defined for 32 bit powerpc (not 64 bit) (and maybe > > > > > > not at all on some architectures e.g. sparc). > > > > > > > > > > > > From Documentation/DMA-API-HOWTO.txt: > > > > > > "All drivers should be using these interfaces with no exceptions. It > > > > > > is planned to completely remove virt_to_bus() and bus_to_virt() as > > > > > > they are entirely deprecated. Some ports already do not provide these > > > > > > as it is impossible to correctly support them." > > > > > > > > > > Drivers that use virt_to_bus should Kconfig depend on VIRT_TO_BUS. > > > > > > > > Ah, I missed that, sorry. I'll go make that change as well. > > > > > > Ping? > > > > Sorry, been swamped with other work, I'll get to this soon... > > ping? > > > With a very relative value of soon. > > Yeah, I understand busy ... but this is a simple patch, rigth? Sorry, I'm away from home, with a very spotty internet connection, on vacation, so it's hard to get this done at the moment. I'll get to it on the 27th when I return. thanks, greg k-h