From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ondrej Zary Subject: Re: [PATCH] media: fix radio-sf16fmr2 build when SND is not enabled Date: Thu, 30 Jun 2011 20:36:49 +0200 Message-ID: <201106302036.56468.linux@rainbow-software.org> References: <20110630165302.12ee1bd0.sfr@canb.auug.org.au> <20110630103104.0a5b8ce6.randy.dunlap@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20110630103104.0a5b8ce6.randy.dunlap@oracle.com> Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org To: Randy Dunlap Cc: Stephen Rothwell , linux-media@vger.kernel.org, linux-next@vger.kernel.org, LKML , Hans Verkuil , Mauro Carvalho Chehab List-Id: linux-next.vger.kernel.org On Thursday 30 June 2011 19:31:04 Randy Dunlap wrote: > From: Randy Dunlap > > When CONFIG_SND is not enabled, radio-sf16fmr2 build fails with: > > ERROR: "snd_tea575x_init" [drivers/media/radio/radio-sf16fmr2.ko] undefined! > ERROR: "snd_tea575x_exit" [drivers/media/radio/radio-sf16fmr2.ko] undefined! > > so make this driver depend on SND. I broke this when converting the driver to use common TEA575x code. Thanks for finding and fixing it. > Signed-off-by: Randy Dunlap > Cc: Hans Verkuil > Cc: Mauro Carvalho Chehab > Cc: linux-media@vger.kernel.org > --- > drivers/media/radio/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- linux-next-20110630.orig/drivers/media/radio/Kconfig > +++ linux-next-20110630/drivers/media/radio/Kconfig > @@ -201,7 +201,7 @@ config RADIO_SF16FMI > > config RADIO_SF16FMR2 > tristate "SF16FMR2 Radio" > - depends on ISA && VIDEO_V4L2 > + depends on ISA && VIDEO_V4L2 && SND > ---help--- > Choose Y here if you have one of these FM radio cards. -- Ondrej Zary