linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Stezenbach <js@sig21.net>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
	Jens Axboe <axboe@kernel.dk>,
	linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
	Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH] compat_ioctl: fix make headers_check regression
Date: Thu, 7 Jul 2011 10:32:29 +0200	[thread overview]
Message-ID: <20110707083229.GA23261@sig21.net> (raw)
In-Reply-To: <20110706161132.c393b685.akpm@linux-foundation.org>

On Wed, Jul 06, 2011 at 04:11:32PM -0700, Andrew Morton wrote:
> On Thu, 7 Jul 2011 00:51:40 +0200
> Johannes Stezenbach <js@sig21.net> wrote:
> 
> > On Mon, Jul 04, 2011 at 12:03:16PM +0200, Johannes Stezenbach wrote:
> > > Fix headers_check error introduced by 390192b30057:
> > > 
> > > include/linux/fd.h:6: included file 'linux/compat.h' is not exported
> > > 
> > > Signed-off-by: Johannes Stezenbach <js@sig21.net>
> > > ---
> > > I used the same style as in linux/usbdevice_fs.h, hope
> > > that's OK.
> > 
> > 
> > I just got an "added to -mm tree" mail for the original patch, so I
> > wonder what's with this fix?
> 
> What does the "original patch" refer to.

"compat_ioctl: fix warning caused by qemu"

> Also, there's no commit 390192b30057.  Commit ID's can change.  This is
> why we ask people to also include the patch title when describing
> patches by SHA ID's

I see, will do in the future

> Please let's just start again.  Tell us what is going on here.

Well, I'm confused by the -mm workflow.  The "original" patch
390192b30057 is in
git://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-3.1/core

http://git.kernel.org/?p=linux/kernel/git/axboe/linux-block.git;a=commit;h=390192b300570b2bc721d77067ca133f58015ae8

And this fix now, too:

http://git.kernel.org/?p=linux/kernel/git/axboe/linux-block.git;a=commit;h=719c0c590609809365c6f3da2f923cd84dc99113


Johannes

  reply	other threads:[~2011-07-07  8:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-04  3:48 linux-next: build failure after merge of the block tree Stephen Rothwell
2011-07-04 10:03 ` [PATCH] compat_ioctl: fix make headers_check regression Johannes Stezenbach
2011-07-06 22:51   ` Johannes Stezenbach
2011-07-06 23:11     ` Andrew Morton
2011-07-07  8:32       ` Johannes Stezenbach [this message]
2011-07-07  6:19   ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110707083229.GA23261@sig21.net \
    --to=js@sig21.net \
    --cc=akpm@linux-foundation.org \
    --cc=arnd@arndb.de \
    --cc=axboe@kernel.dk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).