From: Jean Delvare <khali@linux-fr.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: linux-next: build failure after merge of the jdelvare-hwmon tree
Date: Sat, 16 Jul 2011 17:33:41 +0200 [thread overview]
Message-ID: <20110716173341.06f95d72@endymion.delvare> (raw)
In-Reply-To: <20110716170601.0ffa821a61bbcd8cf6c3a096@canb.auug.org.au>
Hi Stephen,
On Sat, 16 Jul 2011 17:06:01 +1000, Stephen Rothwell wrote:
> After merging the jdelvare-hwmon tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/hwmon/max1111.c: In function 'max1111_remove':
> drivers/hwmon/max1111.c:213:2: error: incompatible type for argument 1 of 'mutex_destroy'
> include/linux/mutex-debug.h:21:13: note: expected 'struct mutex *' but argument is of type 'struct mutex'
>
> Caused by commit d2fbca2996a8 ("hwmon: (max1111) Fix race condition
> causing NULL pointer exception"). Missing '&'?
Oh, right, good catch. It went unnoticed so far because mutex_destroy
resolves to nothing unless CONFIG_DEBUG_MUTEXES=y. I plan to submit a
patch turning the empty implementation of mutex_destroy to an inline
function, so that this kind of problem gets caught earlier.
> I have used the jdelvare-hwmon tree from next-20110707 for today.
Problem is fixed now, thanks.
--
Jean Delvare
prev parent reply other threads:[~2011-07-16 15:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-16 7:06 linux-next: build failure after merge of the jdelvare-hwmon tree Stephen Rothwell
2011-07-16 15:33 ` Jean Delvare [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110716173341.06f95d72@endymion.delvare \
--to=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox