From: Harry Wei <jiaweiwei.xiyou@gmail.com>
To: Randy Dunlap <rdunlap@xenotime.net>
Cc: stefanb@linux.vnet.ibm.com, sfr@canb.auug.org.au,
srajiv@linux.vnet.ibm.com, jmorris@namei.org,
linux-kernel@vger.kernel.org, linux-next@vger.kernel.org,
kongjianjun@gmail.com, harryxiyou@gmail.com
Subject: Re: [PATCH] tpm: Move tpm_tis_reenable_interrupts out of CONFIG_PNP block
Date: Sun, 17 Jul 2011 19:53:23 +0800 [thread overview]
Message-ID: <20110717115320.GA14595@gmail.com> (raw)
In-Reply-To: <20110716223426.f1507465.rdunlap@xenotime.net>
On Sat, Jul 16, 2011 at 10:34:26PM -0700, Randy Dunlap wrote:
> New warning:
> drivers/char/tpm/tpm_tis.c:97: warning: 'is_itpm' defined but not used
From: Harry Wei <harryxiyou@gmail.com>
This patch can fix above warning.
Reported-by: Randy Dunlap <rdunlap@xenotime.net>
Signed-off-by: Harry Wei <harryxiyou@gmail.com>
---
drivers/char/tpm/tpm_tis.c | 20 --------------------
1 files changed, 0 insertions(+), 20 deletions(-)
diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c
index dd21df5..5929bb2 100644
--- a/drivers/char/tpm/tpm_tis.c
+++ b/drivers/char/tpm/tpm_tis.c
@@ -79,26 +79,6 @@ enum tis_defaults {
static LIST_HEAD(tis_chips);
static DEFINE_SPINLOCK(tis_lock);
-#ifdef CONFIG_ACPI
-static int is_itpm(struct pnp_dev *dev)
-{
- struct acpi_device *acpi = pnp_acpi_device(dev);
- struct acpi_hardware_id *id;
-
- list_for_each_entry(id, &acpi->pnp.ids, list) {
- if (!strcmp("INTC0102", id->id))
- return 1;
- }
-
- return 0;
-}
-#else
-static int is_itpm(struct pnp_dev *dev)
-{
- return 0;
-}
-#endif
-
static int check_locality(struct tpm_chip *chip, int l)
{
if ((ioread8(chip->vendor.iobase + TPM_ACCESS(l)) &
--
1.7.0.4
next prev parent reply other threads:[~2011-07-17 11:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-17 5:04 [PATCH] tpm: Move tpm_tis_reenable_interrupts out of CONFIG_PNP block Stefan Berger
2011-07-17 5:34 ` Randy Dunlap
2011-07-17 11:53 ` Harry Wei [this message]
2011-07-17 12:14 ` Stefan Berger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110717115320.GA14595@gmail.com \
--to=jiaweiwei.xiyou@gmail.com \
--cc=harryxiyou@gmail.com \
--cc=jmorris@namei.org \
--cc=kongjianjun@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=rdunlap@xenotime.net \
--cc=sfr@canb.auug.org.au \
--cc=srajiv@linux.vnet.ibm.com \
--cc=stefanb@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).