From mboxrd@z Thu Jan 1 00:00:00 1970 From: Harry Wei Subject: Re: [PATCH] tpm: Move tpm_tis_reenable_interrupts out of CONFIG_PNP block Date: Sun, 17 Jul 2011 19:53:23 +0800 Message-ID: <20110717115320.GA14595@gmail.com> References: <1310879064.15064.4.camel@d941e-10> <20110716223426.f1507465.rdunlap@xenotime.net> Mime-Version: 1.0 Content-Type: text/plain; charset=gb2312 Return-path: Received: from mail-iw0-f174.google.com ([209.85.214.174]:52346 "EHLO mail-iw0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751490Ab1GQLxn (ORCPT ); Sun, 17 Jul 2011 07:53:43 -0400 Content-Disposition: inline In-Reply-To: <20110716223426.f1507465.rdunlap@xenotime.net> Sender: linux-next-owner@vger.kernel.org List-ID: To: Randy Dunlap Cc: stefanb@linux.vnet.ibm.com, sfr@canb.auug.org.au, srajiv@linux.vnet.ibm.com, jmorris@namei.org, linux-kernel@vger.kernel.org, linux-next@vger.kernel.org, kongjianjun@gmail.com, harryxiyou@gmail.com On Sat, Jul 16, 2011 at 10:34:26PM -0700, Randy Dunlap wrote: > New warning: > drivers/char/tpm/tpm_tis.c:97: warning: 'is_itpm' defined but not used From: Harry Wei This patch can fix above warning. Reported-by: Randy Dunlap Signed-off-by: Harry Wei --- drivers/char/tpm/tpm_tis.c | 20 -------------------- 1 files changed, 0 insertions(+), 20 deletions(-) diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c index dd21df5..5929bb2 100644 --- a/drivers/char/tpm/tpm_tis.c +++ b/drivers/char/tpm/tpm_tis.c @@ -79,26 +79,6 @@ enum tis_defaults { static LIST_HEAD(tis_chips); static DEFINE_SPINLOCK(tis_lock); -#ifdef CONFIG_ACPI -static int is_itpm(struct pnp_dev *dev) -{ - struct acpi_device *acpi = pnp_acpi_device(dev); - struct acpi_hardware_id *id; - - list_for_each_entry(id, &acpi->pnp.ids, list) { - if (!strcmp("INTC0102", id->id)) - return 1; - } - - return 0; -} -#else -static int is_itpm(struct pnp_dev *dev) -{ - return 0; -} -#endif - static int check_locality(struct tpm_chip *chip, int l) { if ((ioread8(chip->vendor.iobase + TPM_ACCESS(l)) & -- 1.7.0.4