From: Tejun Heo <tj@kernel.org>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>
Subject: Re: linux-next: manual merge of the ptrace tree with the s390 tree
Date: Fri, 22 Jul 2011 10:06:00 +0200 [thread overview]
Message-ID: <20110722080600.GE2622@htj.dyndns.org> (raw)
In-Reply-To: <20110721144447.GA7580@redhat.com>
On Thu, Jul 21, 2011 at 04:44:47PM +0200, Oleg Nesterov wrote:
> On 07/21, Tejun Heo wrote:
> > Also, I think we really should standardize what gets reported in these
> > debug traps instead of letting each arch do its own thing.
>
> May be we can standardize .si_info within the single arch at least ;)
>
> I never understood what TRAP_HWBKPT/TRAP_BRKPT actually means, and
> I can be easily wrong. But, afaics, on x86 PTRACE_SINGLESTEP results
> in TRAP_TRACE. Unless the tracee steps over syscall, in this case
> user_single_step_siginfo() sets TRAP_BRKPT. Hmm.
>
> And unless I misread 248bed4b0f3c s390 thinks we need TRAP_HWBKPT.
Yeah, it looks like a proper mess. It seems ptrace left too much for
archs to decide. Events to be reported should be defined by generic
ptrace code (there can be some exceptions but only few) and archs
should provide the mechanisms to implement them. I'm planning on
going through ptrace arch specifics soonish. Hopefully it can be
cleaned up somehow.
Thanks.
--
tejun
next prev parent reply other threads:[~2011-07-22 8:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-20 5:33 linux-next: manual merge of the ptrace tree with the s390 tree Stephen Rothwell
2011-07-21 8:02 ` Tejun Heo
2011-07-21 14:44 ` Oleg Nesterov
2011-07-22 8:06 ` Tejun Heo [this message]
2011-07-22 8:29 ` Martin Schwidefsky
2011-07-22 8:48 ` Tejun Heo
2011-07-22 14:49 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110722080600.GE2622@htj.dyndns.org \
--to=tj@kernel.org \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=schwidefsky@de.ibm.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).