Re: linux-next: build warnings after merge of the moduleh tree

[Paul Gortmaker <paul.gortmaker@windriver.com>]

[linux-next: build warnings after merge of the moduleh tree] On 29/07/2011 (Fri 16:09) Stephen Rothwell wrote:

> Hi Paul,
> 
> After merging the moduleh tree, today's linux-next build (powerpc
> ppc64_defconfig) produced these warnings:
> 
> drivers/of/of_pci_irq.c:92:1: warning: data definition has no type or storage class
> drivers/of/of_pci_irq.c:92:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
> drivers/of/of_pci_irq.c:92:1: warning: parameter names (without types) in function declaration
> 
> This is an interaction with commit 98d9f30c820d ("pci/of: Match PCI
> devices to OF nodes dynamically") which split off part of
> drivers/of/of_pci.c.

Thanks, I've picked this one up as well.

Paul.

> 
> I have added this patch for today:
> 
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Fri, 29 Jul 2011 16:05:38 +1000
> Subject: [PATCH] pci/of: include export.h for EXPORT_SYMBOL_GPL
> 
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
>  drivers/of/of_pci_irq.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/of/of_pci_irq.c b/drivers/of/of_pci_irq.c
> index ac1ec54..9312516 100644
> --- a/drivers/of/of_pci_irq.c
> +++ b/drivers/of/of_pci_irq.c
> @@ -1,6 +1,7 @@
>  #include <linux/kernel.h>
>  #include <linux/of_pci.h>
>  #include <linux/of_irq.h>
> +#include <linux/export.h>
>  #include <asm/prom.h>
>  
>  /**
> -- 
> 1.7.5.4
> 
> -- 
> Cheers,
> Stephen Rothwell                    sfr@canb.auug.org.au
> http://www.canb.auug.org.au/~sfr/