* [PATCH -next] x86: files need export.h
2011-07-29 7:38 linux-next: Tree for July 29 Stephen Rothwell
@ 2011-07-29 19:07 ` Randy Dunlap
2011-07-30 18:51 ` Paul Gortmaker
2011-07-29 19:43 ` [PATCH -next] regulator: aat2870 needs module.h Randy Dunlap
` (10 subsequent siblings)
11 siblings, 1 reply; 31+ messages in thread
From: Randy Dunlap @ 2011-07-29 19:07 UTC (permalink / raw)
To: Stephen Rothwell, x86; +Cc: linux-next, LKML
From: Randy Dunlap <rdunlap@xenotime.net>
Fix multiple build errors due to missing export.h header file.
Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
---
arch/x86/kernel/e820.c | 1 +
arch/x86/kernel/pci-dma.c | 1 +
arch/x86/kernel/rtc.c | 1 +
3 files changed, 3 insertions(+)
--- linux-next-20110729.orig/arch/x86/kernel/e820.c
+++ linux-next-20110729/arch/x86/kernel/e820.c
@@ -16,6 +16,7 @@
#include <linux/pfn.h>
#include <linux/suspend.h>
#include <linux/acpi.h>
+#include <linux/export.h>
#include <linux/firmware-map.h>
#include <linux/memblock.h>
#include <linux/sort.h>
--- linux-next-20110729.orig/arch/x86/kernel/pci-dma.c
+++ linux-next-20110729/arch/x86/kernel/pci-dma.c
@@ -1,6 +1,7 @@
#include <linux/dma-mapping.h>
#include <linux/dma-debug.h>
#include <linux/dmar.h>
+#include <linux/export.h>
#include <linux/bootmem.h>
#include <linux/gfp.h>
#include <linux/pci.h>
--- linux-next-20110729.orig/arch/x86/kernel/rtc.c
+++ linux-next-20110729/arch/x86/kernel/rtc.c
@@ -5,6 +5,7 @@
#include <linux/mc146818rtc.h>
#include <linux/acpi.h>
#include <linux/bcd.h>
+#include <linux/export.h>
#include <linux/pnp.h>
#include <linux/of.h>
^ permalink raw reply [flat|nested] 31+ messages in thread* Re: [PATCH -next] x86: files need export.h
2011-07-29 19:07 ` [PATCH -next] x86: files need export.h Randy Dunlap
@ 2011-07-30 18:51 ` Paul Gortmaker
0 siblings, 0 replies; 31+ messages in thread
From: Paul Gortmaker @ 2011-07-30 18:51 UTC (permalink / raw)
To: Randy Dunlap; +Cc: Stephen Rothwell, x86, linux-next, LKML
On Fri, Jul 29, 2011 at 3:07 PM, Randy Dunlap <rdunlap@xenotime.net> wrote:
> From: Randy Dunlap <rdunlap@xenotime.net>
>
> Fix multiple build errors due to missing export.h header file.
I'd already pushed equivalent changes to the branch before seeing
this one.
Thanks,
Paul.
>
> Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
> ---
> arch/x86/kernel/e820.c | 1 +
> arch/x86/kernel/pci-dma.c | 1 +
> arch/x86/kernel/rtc.c | 1 +
> 3 files changed, 3 insertions(+)
>
> --- linux-next-20110729.orig/arch/x86/kernel/e820.c
> +++ linux-next-20110729/arch/x86/kernel/e820.c
> @@ -16,6 +16,7 @@
> #include <linux/pfn.h>
> #include <linux/suspend.h>
> #include <linux/acpi.h>
> +#include <linux/export.h>
> #include <linux/firmware-map.h>
> #include <linux/memblock.h>
> #include <linux/sort.h>
> --- linux-next-20110729.orig/arch/x86/kernel/pci-dma.c
> +++ linux-next-20110729/arch/x86/kernel/pci-dma.c
> @@ -1,6 +1,7 @@
> #include <linux/dma-mapping.h>
> #include <linux/dma-debug.h>
> #include <linux/dmar.h>
> +#include <linux/export.h>
> #include <linux/bootmem.h>
> #include <linux/gfp.h>
> #include <linux/pci.h>
> --- linux-next-20110729.orig/arch/x86/kernel/rtc.c
> +++ linux-next-20110729/arch/x86/kernel/rtc.c
> @@ -5,6 +5,7 @@
> #include <linux/mc146818rtc.h>
> #include <linux/acpi.h>
> #include <linux/bcd.h>
> +#include <linux/export.h>
> #include <linux/pnp.h>
> #include <linux/of.h>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-next" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 31+ messages in thread
* [PATCH -next] regulator: aat2870 needs module.h
2011-07-29 7:38 linux-next: Tree for July 29 Stephen Rothwell
2011-07-29 19:07 ` [PATCH -next] x86: files need export.h Randy Dunlap
@ 2011-07-29 19:43 ` Randy Dunlap
2011-07-30 1:04 ` [PATCH -next] x86: devicetree.h needs export.h Randy Dunlap
` (9 subsequent siblings)
11 siblings, 0 replies; 31+ messages in thread
From: Randy Dunlap @ 2011-07-29 19:43 UTC (permalink / raw)
To: Stephen Rothwell, Liam Girdwood, Mark Brown; +Cc: linux-next, LKML
From: Randy Dunlap <rdunlap@xenotime.net>
aat2870-regulator.c needs to include linux/module.h to fix multiple
build errors.
drivers/regulator/aat2870-regulator.c:145: error: 'THIS_MODULE' undeclared here (not in a function)
drivers/regulator/aat2870-regulator.c:230: warning: type defaults to 'int' in declaration of 'MODULE_DESCRIPTION'
drivers/regulator/aat2870-regulator.c:231: warning: type defaults to 'int' in declaration of 'MODULE_LICENSE'
drivers/regulator/aat2870-regulator.c:232: warning: type defaults to 'int' in declaration of 'MODULE_AUTHOR'
Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
---
drivers/regulator/aat2870-regulator.c | 1 +
1 file changed, 1 insertion(+)
--- linux-next-20110729.orig/drivers/regulator/aat2870-regulator.c
+++ linux-next-20110729/drivers/regulator/aat2870-regulator.c
@@ -22,6 +22,7 @@
#include <linux/kernel.h>
#include <linux/init.h>
#include <linux/err.h>
+#include <linux/module.h>
#include <linux/slab.h>
#include <linux/delay.h>
#include <linux/platform_device.h>
^ permalink raw reply [flat|nested] 31+ messages in thread* [PATCH -next] x86: devicetree.h needs export.h
2011-07-29 7:38 linux-next: Tree for July 29 Stephen Rothwell
2011-07-29 19:07 ` [PATCH -next] x86: files need export.h Randy Dunlap
2011-07-29 19:43 ` [PATCH -next] regulator: aat2870 needs module.h Randy Dunlap
@ 2011-07-30 1:04 ` Randy Dunlap
2011-07-30 19:00 ` Paul Gortmaker
2011-07-30 1:09 ` [PATCH -next] sfi: sfi_acpi.c needs sysfs.h Randy Dunlap
` (8 subsequent siblings)
11 siblings, 1 reply; 31+ messages in thread
From: Randy Dunlap @ 2011-07-30 1:04 UTC (permalink / raw)
To: Stephen Rothwell, x86; +Cc: linux-next, LKML
From: Randy Dunlap <rdunlap@xenotime.net>
devicetree.c needs to include linux/export.h to fix build errors.
Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
---
arch/x86/kernel/devicetree.c | 1 +
1 file changed, 1 insertion(+)
--- linux-next-20110729.orig/arch/x86/kernel/devicetree.c
+++ linux-next-20110729/arch/x86/kernel/devicetree.c
@@ -2,6 +2,7 @@
* Architecture specific OF callbacks.
*/
#include <linux/bootmem.h>
+#include <linux/export.h>
#include <linux/io.h>
#include <linux/interrupt.h>
#include <linux/list.h>
^ permalink raw reply [flat|nested] 31+ messages in thread* Re: [PATCH -next] x86: devicetree.h needs export.h
2011-07-30 1:04 ` [PATCH -next] x86: devicetree.h needs export.h Randy Dunlap
@ 2011-07-30 19:00 ` Paul Gortmaker
0 siblings, 0 replies; 31+ messages in thread
From: Paul Gortmaker @ 2011-07-30 19:00 UTC (permalink / raw)
To: Randy Dunlap; +Cc: Stephen Rothwell, x86, linux-next, LKML
On Fri, Jul 29, 2011 at 9:04 PM, Randy Dunlap <rdunlap@xenotime.net> wrote:
> From: Randy Dunlap <rdunlap@xenotime.net>
>
> devicetree.c needs to include linux/export.h to fix build errors.
Applied to module.h-split, thanks.
P.
>
> Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
> ---
> arch/x86/kernel/devicetree.c | 1 +
> 1 file changed, 1 insertion(+)
>
> --- linux-next-20110729.orig/arch/x86/kernel/devicetree.c
> +++ linux-next-20110729/arch/x86/kernel/devicetree.c
> @@ -2,6 +2,7 @@
> * Architecture specific OF callbacks.
> */
> #include <linux/bootmem.h>
> +#include <linux/export.h>
> #include <linux/io.h>
> #include <linux/interrupt.h>
> #include <linux/list.h>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-next" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 31+ messages in thread
* [PATCH -next] sfi: sfi_acpi.c needs sysfs.h
2011-07-29 7:38 linux-next: Tree for July 29 Stephen Rothwell
` (2 preceding siblings ...)
2011-07-30 1:04 ` [PATCH -next] x86: devicetree.h needs export.h Randy Dunlap
@ 2011-07-30 1:09 ` Randy Dunlap
2011-07-30 19:05 ` Paul Gortmaker
2011-07-30 4:11 ` [PATCH -next] power: max8998_charger.c needs module.h Randy Dunlap
` (7 subsequent siblings)
11 siblings, 1 reply; 31+ messages in thread
From: Randy Dunlap @ 2011-07-30 1:09 UTC (permalink / raw)
To: Stephen Rothwell, lenb, sfi-devel; +Cc: linux-next, LKML
From: Randy Dunlap <rdunlap@xenotime.net>
sfi_acpi.c needs to include linux/sysfs.h for data types.
drivers/sfi/sfi_core.h:66: error: field 'attr' has incomplete type
drivers/sfi/sfi_acpi.c:179: warning: 'struct kobject' declared inside parameter list
drivers/sfi/sfi_acpi.c:179: warning: its scope is only this definition or declaration, which is probably not what you want
drivers/sfi/sfi_acpi.c:182: warning: type defaults to 'int' in declaration of '__mptr'
drivers/sfi/sfi_acpi.c:182: warning: initialization from incompatible pointer type
Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
---
drivers/sfi/sfi_core.h | 3 +++
1 file changed, 3 insertions(+)
--- linux-next-20110729.orig/drivers/sfi/sfi_core.h
+++ linux-next-20110729/drivers/sfi/sfi_core.h
@@ -55,6 +55,9 @@
OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
+
+#include <linux/sysfs.h>
+
struct sfi_table_key{
char *sig;
char *oem_id;
^ permalink raw reply [flat|nested] 31+ messages in thread* Re: [PATCH -next] sfi: sfi_acpi.c needs sysfs.h
2011-07-30 1:09 ` [PATCH -next] sfi: sfi_acpi.c needs sysfs.h Randy Dunlap
@ 2011-07-30 19:05 ` Paul Gortmaker
0 siblings, 0 replies; 31+ messages in thread
From: Paul Gortmaker @ 2011-07-30 19:05 UTC (permalink / raw)
To: Randy Dunlap; +Cc: Stephen Rothwell, lenb, sfi-devel, linux-next, LKML
On Fri, Jul 29, 2011 at 9:09 PM, Randy Dunlap <rdunlap@xenotime.net> wrote:
> From: Randy Dunlap <rdunlap@xenotime.net>
>
> sfi_acpi.c needs to include linux/sysfs.h for data types.
Applied to module.h-split, thanks.
P.
>
> drivers/sfi/sfi_core.h:66: error: field 'attr' has incomplete type
> drivers/sfi/sfi_acpi.c:179: warning: 'struct kobject' declared inside parameter list
> drivers/sfi/sfi_acpi.c:179: warning: its scope is only this definition or declaration, which is probably not what you want
> drivers/sfi/sfi_acpi.c:182: warning: type defaults to 'int' in declaration of '__mptr'
> drivers/sfi/sfi_acpi.c:182: warning: initialization from incompatible pointer type
>
> Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
> ---
> drivers/sfi/sfi_core.h | 3 +++
> 1 file changed, 3 insertions(+)
>
> --- linux-next-20110729.orig/drivers/sfi/sfi_core.h
> +++ linux-next-20110729/drivers/sfi/sfi_core.h
> @@ -55,6 +55,9 @@
> OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
>
> */
> +
> +#include <linux/sysfs.h>
> +
> struct sfi_table_key{
> char *sig;
> char *oem_id;
> --
> To unsubscribe from this list: send the line "unsubscribe linux-next" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 31+ messages in thread
* [PATCH -next] power: max8998_charger.c needs module.h
2011-07-29 7:38 linux-next: Tree for July 29 Stephen Rothwell
` (3 preceding siblings ...)
2011-07-30 1:09 ` [PATCH -next] sfi: sfi_acpi.c needs sysfs.h Randy Dunlap
@ 2011-07-30 4:11 ` Randy Dunlap
2011-08-19 17:02 ` Anton Vorontsov
2011-07-30 4:13 ` [PATCH -next] regulator: aat2870-regulator.c " Randy Dunlap
` (6 subsequent siblings)
11 siblings, 1 reply; 31+ messages in thread
From: Randy Dunlap @ 2011-07-30 4:11 UTC (permalink / raw)
To: Stephen Rothwell, Anton Vorontsov, David Woodhouse; +Cc: linux-next, LKML, akpm
From: Randy Dunlap <rdunlap@xenotime.net>
power/max8998_charger.c uses interfaces from linux/module.h,
so it should include that file. This fixes build errors.
Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
---
drivers/power/max8998_charger.c | 1 +
1 file changed, 1 insertion(+)
--- linux-next-20110729.orig/drivers/power/max8998_charger.c
+++ linux-next-20110729/drivers/power/max8998_charger.c
@@ -20,6 +20,7 @@
*/
#include <linux/err.h>
+#include <linux/module.h>
#include <linux/slab.h>
#include <linux/platform_device.h>
#include <linux/power_supply.h>
^ permalink raw reply [flat|nested] 31+ messages in thread* Re: [PATCH -next] power: max8998_charger.c needs module.h
2011-07-30 4:11 ` [PATCH -next] power: max8998_charger.c needs module.h Randy Dunlap
@ 2011-08-19 17:02 ` Anton Vorontsov
0 siblings, 0 replies; 31+ messages in thread
From: Anton Vorontsov @ 2011-08-19 17:02 UTC (permalink / raw)
To: Randy Dunlap; +Cc: Stephen Rothwell, David Woodhouse, linux-next, LKML, akpm
On Fri, Jul 29, 2011 at 09:11:43PM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@xenotime.net>
>
> power/max8998_charger.c uses interfaces from linux/module.h,
> so it should include that file. This fixes build errors.
>
> Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
> ---
Applied, thank you!
--
Anton Vorontsov
Email: cbouatmailru@gmail.com
^ permalink raw reply [flat|nested] 31+ messages in thread
* [PATCH -next] regulator: aat2870-regulator.c needs module.h
2011-07-29 7:38 linux-next: Tree for July 29 Stephen Rothwell
` (4 preceding siblings ...)
2011-07-30 4:11 ` [PATCH -next] power: max8998_charger.c needs module.h Randy Dunlap
@ 2011-07-30 4:13 ` Randy Dunlap
2011-08-01 0:15 ` Mark Brown
2011-07-30 4:14 ` [PATCH -next] sound: rtctimer.c " Randy Dunlap
` (5 subsequent siblings)
11 siblings, 1 reply; 31+ messages in thread
From: Randy Dunlap @ 2011-07-30 4:13 UTC (permalink / raw)
To: Stephen Rothwell, akpm; +Cc: linux-next, LKML, Liam Girdwood, Mark Brown
From: Randy Dunlap <rdunlap@xenotime.net>
aat2870-regulator.c needs to include linux/module.h to fix multiple
build errors.
drivers/regulator/aat2870-regulator.c:145: error: 'THIS_MODULE' undeclared here (not in a function)
drivers/regulator/aat2870-regulator.c:230: warning: type defaults to 'int' in declaration of 'MODULE_DESCRIPTION'
drivers/regulator/aat2870-regulator.c:231: warning: type defaults to 'int' in declaration of 'MODULE_LICENSE'
drivers/regulator/aat2870-regulator.c:232: warning: type defaults to 'int' in declaration of 'MODULE_AUTHOR'
Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
---
drivers/regulator/aat2870-regulator.c | 1 +
1 file changed, 1 insertion(+)
--- linux-next-20110729.orig/drivers/regulator/aat2870-regulator.c
+++ linux-next-20110729/drivers/regulator/aat2870-regulator.c
@@ -22,6 +22,7 @@
#include <linux/kernel.h>
#include <linux/init.h>
#include <linux/err.h>
+#include <linux/module.h>
#include <linux/slab.h>
#include <linux/delay.h>
#include <linux/platform_device.h>
^ permalink raw reply [flat|nested] 31+ messages in thread* Re: [PATCH -next] regulator: aat2870-regulator.c needs module.h
2011-07-30 4:13 ` [PATCH -next] regulator: aat2870-regulator.c " Randy Dunlap
@ 2011-08-01 0:15 ` Mark Brown
2011-08-01 0:33 ` Stephen Rothwell
0 siblings, 1 reply; 31+ messages in thread
From: Mark Brown @ 2011-08-01 0:15 UTC (permalink / raw)
To: Randy Dunlap; +Cc: Stephen Rothwell, akpm, linux-next, LKML, Liam Girdwood
On Fri, Jul 29, 2011 at 09:13:09PM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@xenotime.net>
>
> aat2870-regulator.c needs to include linux/module.h to fix multiple
> build errors.
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
but if the breakage isn't in mainline yet to minimize the breaks
bisection someone should figure out which tree introduced the change
with module.h and either get the fix merged along with that. If neither
the module.h change nor the driver is in Linus' tree yet I rather
suspect this should go via MFD as I seem to recall that the driver is
going in via there.
It's not entirely clear to me why this started showing up part way
through the merge window :/
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PATCH -next] regulator: aat2870-regulator.c needs module.h
2011-08-01 0:15 ` Mark Brown
@ 2011-08-01 0:33 ` Stephen Rothwell
2011-08-01 1:05 ` Stephen Rothwell
0 siblings, 1 reply; 31+ messages in thread
From: Stephen Rothwell @ 2011-08-01 0:33 UTC (permalink / raw)
To: Mark Brown
Cc: Randy Dunlap, akpm, linux-next, LKML, Liam Girdwood, Samuel Ortiz
[-- Attachment #1: Type: text/plain, Size: 1266 bytes --]
On Mon, 1 Aug 2011 01:15:24 +0100 Mark Brown <broonie@opensource.wolfsonmicro.com> wrote:
>
> On Fri, Jul 29, 2011 at 09:13:09PM -0700, Randy Dunlap wrote:
> > From: Randy Dunlap <rdunlap@xenotime.net>
> >
> > aat2870-regulator.c needs to include linux/module.h to fix multiple
> > build errors.
>
> Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
>
> but if the breakage isn't in mainline yet to minimize the breaks
> bisection someone should figure out which tree introduced the change
> with module.h and either get the fix merged along with that. If neither
> the module.h change nor the driver is in Linus' tree yet I rather
> suspect this should go via MFD as I seem to recall that the driver is
> going in via there.
It is indeed. I have this patch set to apply to my tree today after the
mfd tree. Hopefully Samuel will put it in his tree for tomorrow (and
before he asks Linus to pull.
> It's not entirely clear to me why this started showing up part way
> through the merge window :/
Various people thought that the module.h split up was worth the effort,
so it got dropped into linux-next on Friday.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PATCH -next] regulator: aat2870-regulator.c needs module.h
2011-08-01 0:33 ` Stephen Rothwell
@ 2011-08-01 1:05 ` Stephen Rothwell
2011-08-01 9:25 ` Samuel Ortiz
0 siblings, 1 reply; 31+ messages in thread
From: Stephen Rothwell @ 2011-08-01 1:05 UTC (permalink / raw)
To: Mark Brown
Cc: Randy Dunlap, akpm, linux-next, LKML, Liam Girdwood, Samuel Ortiz
[-- Attachment #1: Type: text/plain, Size: 1183 bytes --]
On Mon, 1 Aug 2011 10:33:04 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> On Mon, 1 Aug 2011 01:15:24 +0100 Mark Brown <broonie@opensource.wolfsonmicro.com> wrote:
> >
> > On Fri, Jul 29, 2011 at 09:13:09PM -0700, Randy Dunlap wrote:
> > > From: Randy Dunlap <rdunlap@xenotime.net>
> > >
> > > aat2870-regulator.c needs to include linux/module.h to fix multiple
> > > build errors.
> >
> > Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> >
> > but if the breakage isn't in mainline yet to minimize the breaks
> > bisection someone should figure out which tree introduced the change
> > with module.h and either get the fix merged along with that. If neither
> > the module.h change nor the driver is in Linus' tree yet I rather
> > suspect this should go via MFD as I seem to recall that the driver is
> > going in via there.
>
> It is indeed. I have this patch set to apply to my tree today after the
> mfd tree. Hopefully Samuel will put it in his tree for tomorrow (and
> before he asks Linus to pull.
Too late :-)
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PATCH -next] regulator: aat2870-regulator.c needs module.h
2011-08-01 1:05 ` Stephen Rothwell
@ 2011-08-01 9:25 ` Samuel Ortiz
2011-08-01 18:09 ` Liam Girdwood
0 siblings, 1 reply; 31+ messages in thread
From: Samuel Ortiz @ 2011-08-01 9:25 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Mark Brown, Randy Dunlap, akpm, linux-next, LKML, Liam Girdwood
Hi Stephen, Liam,
On Mon, Aug 01, 2011 at 11:05:07AM +1000, Stephen Rothwell wrote:
> On Mon, 1 Aug 2011 10:33:04 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > On Mon, 1 Aug 2011 01:15:24 +0100 Mark Brown <broonie@opensource.wolfsonmicro.com> wrote:
> > >
> > > On Fri, Jul 29, 2011 at 09:13:09PM -0700, Randy Dunlap wrote:
> > > > From: Randy Dunlap <rdunlap@xenotime.net>
> > > >
> > > > aat2870-regulator.c needs to include linux/module.h to fix multiple
> > > > build errors.
> > >
> > > Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> > >
> > > but if the breakage isn't in mainline yet to minimize the breaks
> > > bisection someone should figure out which tree introduced the change
> > > with module.h and either get the fix merged along with that. If neither
> > > the module.h change nor the driver is in Linus' tree yet I rather
> > > suspect this should go via MFD as I seem to recall that the driver is
> > > going in via there.
> >
> > It is indeed. I have this patch set to apply to my tree today after the
> > mfd tree. Hopefully Samuel will put it in his tree for tomorrow (and
> > before he asks Linus to pull.
>
> Too late :-)
Sorry about that. I thought I would hear about any breakage after I pushed my
bits on Friday morning.
Anyway, Liam, are you going to push this fix through your tree ?
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PATCH -next] regulator: aat2870-regulator.c needs module.h
2011-08-01 9:25 ` Samuel Ortiz
@ 2011-08-01 18:09 ` Liam Girdwood
2011-08-03 10:28 ` Samuel Ortiz
0 siblings, 1 reply; 31+ messages in thread
From: Liam Girdwood @ 2011-08-01 18:09 UTC (permalink / raw)
To: Samuel Ortiz
Cc: Stephen Rothwell, Mark Brown, Randy Dunlap, akpm,
linux-next@vger.kernel.org, LKML
Hi Samuel,
On Mon, 2011-08-01 at 11:25 +0200, Samuel Ortiz wrote:
> Hi Stephen, Liam,
>
> On Mon, Aug 01, 2011 at 11:05:07AM +1000, Stephen Rothwell wrote:
> > On Mon, 1 Aug 2011 10:33:04 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > >
> > > On Mon, 1 Aug 2011 01:15:24 +0100 Mark Brown <broonie@opensource.wolfsonmicro.com> wrote:
> > > >
> > > > On Fri, Jul 29, 2011 at 09:13:09PM -0700, Randy Dunlap wrote:
> > > > > From: Randy Dunlap <rdunlap@xenotime.net>
> > > > >
> > > > > aat2870-regulator.c needs to include linux/module.h to fix multiple
> > > > > build errors.
> > > >
> > > > Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> > > >
> > > > but if the breakage isn't in mainline yet to minimize the breaks
> > > > bisection someone should figure out which tree introduced the change
> > > > with module.h and either get the fix merged along with that. If neither
> > > > the module.h change nor the driver is in Linus' tree yet I rather
> > > > suspect this should go via MFD as I seem to recall that the driver is
> > > > going in via there.
> > >
> > > It is indeed. I have this patch set to apply to my tree today after the
> > > mfd tree. Hopefully Samuel will put it in his tree for tomorrow (and
> > > before he asks Linus to pull.
> >
> > Too late :-)
> Sorry about that. I thought I would hear about any breakage after I pushed my
> bits on Friday morning.
> Anyway, Liam, are you going to push this fix through your tree ?
>
I can if required, however I've just done my pull request (sorry didn't
see this in time). I have to do another pull request with misc fixes in
rc1 time frame so I can add it there if OK.
Thanks
Liam
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PATCH -next] regulator: aat2870-regulator.c needs module.h
2011-08-01 18:09 ` Liam Girdwood
@ 2011-08-03 10:28 ` Samuel Ortiz
0 siblings, 0 replies; 31+ messages in thread
From: Samuel Ortiz @ 2011-08-03 10:28 UTC (permalink / raw)
To: Liam Girdwood
Cc: Stephen Rothwell, Mark Brown, Randy Dunlap, akpm,
linux-next@vger.kernel.org, LKML
Hi Liam,
On Mon, Aug 01, 2011 at 07:09:46PM +0100, Liam Girdwood wrote:
> Hi Samuel,
>
> On Mon, 2011-08-01 at 11:25 +0200, Samuel Ortiz wrote:
> > Hi Stephen, Liam,
> >
> > On Mon, Aug 01, 2011 at 11:05:07AM +1000, Stephen Rothwell wrote:
> > > On Mon, 1 Aug 2011 10:33:04 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > > >
> > > > On Mon, 1 Aug 2011 01:15:24 +0100 Mark Brown <broonie@opensource.wolfsonmicro.com> wrote:
> > > > >
> > > > > On Fri, Jul 29, 2011 at 09:13:09PM -0700, Randy Dunlap wrote:
> > > > > > From: Randy Dunlap <rdunlap@xenotime.net>
> > > > > >
> > > > > > aat2870-regulator.c needs to include linux/module.h to fix multiple
> > > > > > build errors.
> > > > >
> > > > > Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> > > > >
> > > > > but if the breakage isn't in mainline yet to minimize the breaks
> > > > > bisection someone should figure out which tree introduced the change
> > > > > with module.h and either get the fix merged along with that. If neither
> > > > > the module.h change nor the driver is in Linus' tree yet I rather
> > > > > suspect this should go via MFD as I seem to recall that the driver is
> > > > > going in via there.
> > > >
> > > > It is indeed. I have this patch set to apply to my tree today after the
> > > > mfd tree. Hopefully Samuel will put it in his tree for tomorrow (and
> > > > before he asks Linus to pull.
> > >
> > > Too late :-)
> > Sorry about that. I thought I would hear about any breakage after I pushed my
> > bits on Friday morning.
> > Anyway, Liam, are you going to push this fix through your tree ?
> >
>
> I can if required, however I've just done my pull request (sorry didn't
> see this in time). I have to do another pull request with misc fixes in
> rc1 time frame so I can add it there if OK.
That's fine with me, thanks in advance.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
^ permalink raw reply [flat|nested] 31+ messages in thread
* [PATCH -next] sound: rtctimer.c needs module.h
2011-07-29 7:38 linux-next: Tree for July 29 Stephen Rothwell
` (5 preceding siblings ...)
2011-07-30 4:13 ` [PATCH -next] regulator: aat2870-regulator.c " Randy Dunlap
@ 2011-07-30 4:14 ` Randy Dunlap
2011-07-30 6:04 ` Takashi Iwai
2011-07-30 4:14 ` [PATCH -next] i2c: i2c-pxa-pci.c " Randy Dunlap
` (4 subsequent siblings)
11 siblings, 1 reply; 31+ messages in thread
From: Randy Dunlap @ 2011-07-30 4:14 UTC (permalink / raw)
To: Stephen Rothwell, akpm; +Cc: linux-next, LKML, Takashi Iwai, alsa-devel
From: Randy Dunlap <rdunlap@xenotime.net>
rtctimer.c uses interfaces from linux/module.h, so it should
include that file. This fixes build errors.
Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
---
sound/core/rtctimer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-next-20110729.orig/sound/core/rtctimer.c
+++ linux-next-20110729/sound/core/rtctimer.c
@@ -22,7 +22,7 @@
#include <linux/init.h>
#include <linux/interrupt.h>
-#include <linux/moduleparam.h>
+#include <linux/module.h>
#include <linux/log2.h>
#include <sound/core.h>
#include <sound/timer.h>
^ permalink raw reply [flat|nested] 31+ messages in thread* Re: [PATCH -next] sound: rtctimer.c needs module.h
2011-07-30 4:14 ` [PATCH -next] sound: rtctimer.c " Randy Dunlap
@ 2011-07-30 6:04 ` Takashi Iwai
0 siblings, 0 replies; 31+ messages in thread
From: Takashi Iwai @ 2011-07-30 6:04 UTC (permalink / raw)
To: Randy Dunlap; +Cc: Stephen Rothwell, akpm, linux-next, LKML, alsa-devel
At Fri, 29 Jul 2011 21:14:12 -0700,
Randy Dunlap wrote:
>
> From: Randy Dunlap <rdunlap@xenotime.net>
>
> rtctimer.c uses interfaces from linux/module.h, so it should
> include that file. This fixes build errors.
>
> Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
Applied now. Thanks.
Takashi
> ---
> sound/core/rtctimer.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-next-20110729.orig/sound/core/rtctimer.c
> +++ linux-next-20110729/sound/core/rtctimer.c
> @@ -22,7 +22,7 @@
>
> #include <linux/init.h>
> #include <linux/interrupt.h>
> -#include <linux/moduleparam.h>
> +#include <linux/module.h>
> #include <linux/log2.h>
> #include <sound/core.h>
> #include <sound/timer.h>
>
^ permalink raw reply [flat|nested] 31+ messages in thread
* [PATCH -next] i2c: i2c-pxa-pci.c needs module.h
2011-07-29 7:38 linux-next: Tree for July 29 Stephen Rothwell
` (6 preceding siblings ...)
2011-07-30 4:14 ` [PATCH -next] sound: rtctimer.c " Randy Dunlap
@ 2011-07-30 4:14 ` Randy Dunlap
[not found] ` <20110729211430.6c4830bd.rdunlap-/UHa2rfvQTnk1uMJSBkQmQ@public.gmane.org>
2011-07-30 4:14 ` [PATCH -next] input: mouse/hgpk.c " Randy Dunlap
` (3 subsequent siblings)
11 siblings, 1 reply; 31+ messages in thread
From: Randy Dunlap @ 2011-07-30 4:14 UTC (permalink / raw)
To: Stephen Rothwell, linux-i2c, akpm; +Cc: linux-next, LKML, khali, ben-linux
From: Randy Dunlap <rdunlap@xenotime.net>
i2c-pxa-pci.c uses interfaces from linux/module.h, so it should
include that file. This fixes build errors.
Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
---
drivers/i2c/busses/i2c-pxa-pci.c | 1 +
1 file changed, 1 insertion(+)
--- linux-next-20110729.orig/drivers/i2c/busses/i2c-pxa-pci.c
+++ linux-next-20110729/drivers/i2c/busses/i2c-pxa-pci.c
@@ -3,6 +3,7 @@
* It does not support slave mode, the register slightly moved. This PCI
* device provides three bars, every contains a single I2C controller.
*/
+#include <linux/module.h>
#include <linux/pci.h>
#include <linux/platform_device.h>
#include <linux/i2c/pxa-i2c.h>
^ permalink raw reply [flat|nested] 31+ messages in thread* [PATCH -next] input: mouse/hgpk.c needs module.h
2011-07-29 7:38 linux-next: Tree for July 29 Stephen Rothwell
` (7 preceding siblings ...)
2011-07-30 4:14 ` [PATCH -next] i2c: i2c-pxa-pci.c " Randy Dunlap
@ 2011-07-30 4:14 ` Randy Dunlap
2011-07-30 19:02 ` Dmitry Torokhov
2011-07-30 4:14 ` [PATCH -next] x86/platform: geode/alix.c " Randy Dunlap
` (2 subsequent siblings)
11 siblings, 1 reply; 31+ messages in thread
From: Randy Dunlap @ 2011-07-30 4:14 UTC (permalink / raw)
To: Stephen Rothwell, Dmitry Torokhov; +Cc: linux-next, LKML, linux-input, akpm
From: Randy Dunlap <rdunlap@xenotime.net>
hgpk.c uses interfaces from linux/module.h, so it should
include that file. This fixes build errors.
Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
---
drivers/input/mouse/hgpk.c | 1 +
1 file changed, 1 insertion(+)
--- linux-next-20110729.orig/drivers/input/mouse/hgpk.c
+++ linux-next-20110729/drivers/input/mouse/hgpk.c
@@ -32,6 +32,7 @@
#define DEBUG
#include <linux/slab.h>
#include <linux/input.h>
+#include <linux/module.h>
#include <linux/serio.h>
#include <linux/libps2.h>
#include <linux/delay.h>
^ permalink raw reply [flat|nested] 31+ messages in thread* Re: [PATCH -next] input: mouse/hgpk.c needs module.h
2011-07-30 4:14 ` [PATCH -next] input: mouse/hgpk.c " Randy Dunlap
@ 2011-07-30 19:02 ` Dmitry Torokhov
0 siblings, 0 replies; 31+ messages in thread
From: Dmitry Torokhov @ 2011-07-30 19:02 UTC (permalink / raw)
To: Randy Dunlap; +Cc: Stephen Rothwell, linux-next, LKML, linux-input, akpm
On Fri, Jul 29, 2011 at 09:14:41PM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@xenotime.net>
>
> hgpk.c uses interfaces from linux/module.h, so it should
> include that file. This fixes build errors.
>
> Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
Applied, thanks Randy.
--
Dmitry
^ permalink raw reply [flat|nested] 31+ messages in thread
* [PATCH -next] x86/platform: geode/alix.c needs module.h
2011-07-29 7:38 linux-next: Tree for July 29 Stephen Rothwell
` (8 preceding siblings ...)
2011-07-30 4:14 ` [PATCH -next] input: mouse/hgpk.c " Randy Dunlap
@ 2011-07-30 4:14 ` Randy Dunlap
2011-07-30 4:14 ` [PATCH -next] x86/platform: mrst/pmu.c " Randy Dunlap
2011-07-30 11:38 ` linux-next: Tree for July 29 Sedat Dilek
11 siblings, 0 replies; 31+ messages in thread
From: Randy Dunlap @ 2011-07-30 4:14 UTC (permalink / raw)
To: Stephen Rothwell, Andres Salomon, linux-geode
Cc: linux-next, LKML, Matthew Garrett, platform-driver-x86, akpm
From: Randy Dunlap <rdunlap@xenotime.net>
geode/alix.c uses interfaces from linux/module.h, so it should
include that file. This fixes build errors.
Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
---
arch/x86/platform/geode/alix.c | 1 +
1 file changed, 1 insertion(+)
--- linux-next-20110729.orig/arch/x86/platform/geode/alix.c
+++ linux-next-20110729/arch/x86/platform/geode/alix.c
@@ -19,6 +19,7 @@
#include <linux/kernel.h>
#include <linux/init.h>
#include <linux/io.h>
+#include <linux/module.h>
#include <linux/string.h>
#include <linux/leds.h>
#include <linux/platform_device.h>
^ permalink raw reply [flat|nested] 31+ messages in thread* [PATCH -next] x86/platform: mrst/pmu.c needs module.h
2011-07-29 7:38 linux-next: Tree for July 29 Stephen Rothwell
` (9 preceding siblings ...)
2011-07-30 4:14 ` [PATCH -next] x86/platform: geode/alix.c " Randy Dunlap
@ 2011-07-30 4:14 ` Randy Dunlap
2011-08-01 15:31 ` Len Brown
2011-07-30 11:38 ` linux-next: Tree for July 29 Sedat Dilek
11 siblings, 1 reply; 31+ messages in thread
From: Randy Dunlap @ 2011-07-30 4:14 UTC (permalink / raw)
To: Stephen Rothwell, Len Brown, linux-pm
Cc: linux-next, LKML, Matthew Garrett, platform-driver-x86, akpm
From: Randy Dunlap <rdunlap@xenotime.net>
mrst/pmu.c uses interfaces from linux/module.h, so it should
include that file. This fixes build errors.
Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
---
arch/x86/platform/mrst/pmu.c | 1 +
1 file changed, 1 insertion(+)
--- linux-next-20110729.orig/arch/x86/platform/mrst/pmu.c
+++ linux-next-20110729/arch/x86/platform/mrst/pmu.c
@@ -21,6 +21,7 @@
#include <linux/debugfs.h>
#include <linux/delay.h>
#include <linux/interrupt.h>
+#include <linux/module.h>
#include <linux/pci.h>
#include <linux/seq_file.h>
#include <linux/sfi.h>
^ permalink raw reply [flat|nested] 31+ messages in thread* Re: [PATCH -next] x86/platform: mrst/pmu.c needs module.h
2011-07-30 4:14 ` [PATCH -next] x86/platform: mrst/pmu.c " Randy Dunlap
@ 2011-08-01 15:31 ` Len Brown
0 siblings, 0 replies; 31+ messages in thread
From: Len Brown @ 2011-08-01 15:31 UTC (permalink / raw)
To: Randy Dunlap
Cc: Stephen Rothwell, Len Brown, linux-pm, linux-next, LKML,
Matthew Garrett, platform-driver-x86, akpm
applied
thanks,
Len Brown, Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: linux-next: Tree for July 29
2011-07-29 7:38 linux-next: Tree for July 29 Stephen Rothwell
` (10 preceding siblings ...)
2011-07-30 4:14 ` [PATCH -next] x86/platform: mrst/pmu.c " Randy Dunlap
@ 2011-07-30 11:38 ` Sedat Dilek
2011-07-30 16:08 ` Arnaud Lacombe
11 siblings, 1 reply; 31+ messages in thread
From: Sedat Dilek @ 2011-07-30 11:38 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: linux-next, LKML, Randy Dunlap
On Fri, Jul 29, 2011 at 9:38 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi all,
>
> Just in case anyone needs reminding: Please do not add anything destined
> for v3.2 into linux-next included trees until after v3.1-rc1.
>
> The powerpc allyesconfig and sparc defconfig build (at least) fail today.
>
> Changes since 20110728:
>
> New tree: moduleh
>
See all those followup/fixup patches the last day, might be not such a
good idea to include this tree :-).
I wait for next Monday's linux-next.
- Sedat -
^ permalink raw reply [flat|nested] 31+ messages in thread* Re: linux-next: Tree for July 29
2011-07-30 11:38 ` linux-next: Tree for July 29 Sedat Dilek
@ 2011-07-30 16:08 ` Arnaud Lacombe
2011-07-30 16:16 ` Sedat Dilek
0 siblings, 1 reply; 31+ messages in thread
From: Arnaud Lacombe @ 2011-07-30 16:08 UTC (permalink / raw)
To: sedat.dilek; +Cc: Stephen Rothwell, linux-next, LKML, Randy Dunlap
Hi,
On Sat, Jul 30, 2011 at 7:38 AM, Sedat Dilek <sedat.dilek@googlemail.com> wrote:
> On Fri, Jul 29, 2011 at 9:38 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>> Hi all,
>>
>> Just in case anyone needs reminding: Please do not add anything destined
>> for v3.2 into linux-next included trees until after v3.1-rc1.
>>
>> The powerpc allyesconfig and sparc defconfig build (at least) fail today.
>>
>> Changes since 20110728:
>>
>> New tree: moduleh
>>
>
> See all those followup/fixup patches the last day, might be not such a
> good idea to include this tree :-).
In the opposite, that is all the point of including a tree in -next:
give expose to code :)
- Arnaud
> I wait for next Monday's linux-next.
>
> - Sedat -
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: linux-next: Tree for July 29
2011-07-30 16:08 ` Arnaud Lacombe
@ 2011-07-30 16:16 ` Sedat Dilek
0 siblings, 0 replies; 31+ messages in thread
From: Sedat Dilek @ 2011-07-30 16:16 UTC (permalink / raw)
To: Arnaud Lacombe; +Cc: Stephen Rothwell, linux-next, LKML, Randy Dunlap
On Sat, Jul 30, 2011 at 6:08 PM, Arnaud Lacombe <lacombar@gmail.com> wrote:
> Hi,
>
> On Sat, Jul 30, 2011 at 7:38 AM, Sedat Dilek <sedat.dilek@googlemail.com> wrote:
>> On Fri, Jul 29, 2011 at 9:38 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>>> Hi all,
>>>
>>> Just in case anyone needs reminding: Please do not add anything destined
>>> for v3.2 into linux-next included trees until after v3.1-rc1.
>>>
>>> The powerpc allyesconfig and sparc defconfig build (at least) fail today.
>>>
>>> Changes since 20110728:
>>>
>>> New tree: moduleh
>>>
>>
>> See all those followup/fixup patches the last day, might be not such a
>> good idea to include this tree :-).
> In the opposite, that is all the point of including a tree in -next:
> give expose to code :)
>
Agreed... and I know about the risks of linux-next (even as a
Debian/sid user) :-).
- Sedat -
> - Arnaud
>
>> I wait for next Monday's linux-next.
>>
>> - Sedat -
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>> Please read the FAQ at http://www.tux.org/lkml/
>>
>
^ permalink raw reply [flat|nested] 31+ messages in thread