linux-next: build failure after merge of the pci-current tree

linux-next: build failure after merge of the pci-current tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 487 bytes --]

Hi Jesse,

After merging the pci-current tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

ERROR: ".pcie_bus_configure_settings" [drivers/pci/hotplug/pci_hotplug.ko] undefined!

Caused by commit b03e7495a862 ("PCI: Set PCI-E Max Payload Size on
fabric").  Missing EXPORT_SYMBOL?

I have used the pci-current tree from next-20110801 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: linux-next: build failure after merge of the pci-current tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 653 bytes --]

Hi Jesse,

On Tue, 2 Aug 2011 10:48:38 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the pci-current tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
> 
> ERROR: ".pcie_bus_configure_settings" [drivers/pci/hotplug/pci_hotplug.ko] undefined!
> 
> Caused by commit b03e7495a862 ("PCI: Set PCI-E Max Payload Size on
> fabric").  Missing EXPORT_SYMBOL?
> 
> I have used the pci-current tree from next-20110801 for today.

And the same for the pci tree (which is identical today).

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

[PATCH] PCI: export pcie_bus_configure_settings symbol

[Jon Mason]

pcie_bus_configure_settings needs to be exported if the PCI hotplug
driver is being compiled as a module.

Discovered by Stephen Rothwell

Signed-off-by: Jon Mason <mason@myri.com>
---
 drivers/pci/probe.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c
index 5becf7c..8473727 100644
--- a/drivers/pci/probe.c
+++ b/drivers/pci/probe.c
@@ -1470,6 +1470,7 @@ void pcie_bus_configure_settings(struct pci_bus *bus, u8 mpss)
 	pcie_bus_configure_set(bus->self, &smpss);
 	pci_walk_bus(bus, pcie_bus_configure_set, &smpss);
 }
+EXPORT_SYMBOL_GPL(pcie_bus_configure_settings);
 
 unsigned int __devinit pci_scan_child_bus(struct pci_bus *bus)
 {
-- 
1.7.6

Re: linux-next: build failure after merge of the pci-current tree

[Jesse Barnes]

On Tue, 2 Aug 2011 11:23:36 +1000
Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> Hi Jesse,
> 
> On Tue, 2 Aug 2011 10:48:38 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > After merging the pci-current tree, today's linux-next build (powerpc
> > ppc64_defconfig) failed like this:
> > 
> > ERROR: ".pcie_bus_configure_settings" [drivers/pci/hotplug/pci_hotplug.ko] undefined!
> > 
> > Caused by commit b03e7495a862 ("PCI: Set PCI-E Max Payload Size on
> > fabric").  Missing EXPORT_SYMBOL?
> > 
> > I have used the pci-current tree from next-20110801 for today.
> 
> And the same for the pci tree (which is identical today).

Jon just sent me the fix and I pushed it out.  Should be fixed now.

Thanks,
-- 
Jesse Barnes, Intel Open Source Technology Center