From: Ingo Molnar <mingo@elte.hu>
To: Randy Dunlap <rdunlap@xenotime.net>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Leendert van Doorn <leendert@watson.ibm.com>,
linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
James Morris <jmorris@namei.org>,
tpmdd-devel@lists.sourceforge.net,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH -next] tpm_tis: fix build when ACPI is not enabled
Date: Wed, 3 Aug 2011 20:56:34 +0200 [thread overview]
Message-ID: <20110803185634.GA16988@elte.hu> (raw)
In-Reply-To: <20110727114211.18be47cf.rdunlap@xenotime.net>
* Randy Dunlap <rdunlap@xenotime.net> wrote:
> From: Randy Dunlap <rdunlap@xenotime.net>
>
> Fix tpm_tis.c build when CONFIG_ACPI is not enabled by providing
> a stub function. Fixes many build errors/warnings:
>
> drivers/char/tpm/tpm_tis.c:89: error: dereferencing pointer to incomplete type
> drivers/char/tpm/tpm_tis.c:89: warning: type defaults to 'int' in declaration of 'type name'
> drivers/char/tpm/tpm_tis.c:89: error: request for member 'list' in something not a structure or union
> drivers/char/tpm/tpm_tis.c:89: warning: type defaults to 'int' in declaration of '__mptr'
> drivers/char/tpm/tpm_tis.c:89: error: dereferencing pointer to incomplete type
> drivers/char/tpm/tpm_tis.c:89: error: dereferencing pointer to incomplete type
> drivers/char/tpm/tpm_tis.c:89: error: dereferencing pointer to incomplete type
> drivers/char/tpm/tpm_tis.c:89: warning: type defaults to 'int' in declaration of 'type name'
> drivers/char/tpm/tpm_tis.c:89: error: request for member 'list' in something not a structure or union
> drivers/char/tpm/tpm_tis.c:89: warning: type defaults to 'int' in declaration of 'type name'
> drivers/char/tpm/tpm_tis.c:89: error: dereferencing pointer to incomplete type
> drivers/char/tpm/tpm_tis.c:89: error: dereferencing pointer to incomplete type
> drivers/char/tpm/tpm_tis.c:89: error: dereferencing pointer to incomplete type
> drivers/char/tpm/tpm_tis.c:89: warning: type defaults to 'int' in declaration of 'type name'
> drivers/char/tpm/tpm_tis.c:89: error: request for member 'list' in something not a structure or union
> drivers/char/tpm/tpm_tis.c:89: warning: type defaults to 'int' in declaration of '__mptr'
> drivers/char/tpm/tpm_tis.c:89: error: dereferencing pointer to incomplete type
> drivers/char/tpm/tpm_tis.c:89: error: dereferencing pointer to incomplete type
> drivers/char/tpm/tpm_tis.c:89: error: dereferencing pointer to incomplete type
> drivers/char/tpm/tpm_tis.c:89: warning: type defaults to 'int' in declaration of 'type name'
> drivers/char/tpm/tpm_tis.c:89: error: request for member 'list' in something not a structure or union
> drivers/char/tpm/tpm_tis.c:89: warning: type defaults to 'int' in declaration of 'type name'
> drivers/char/tpm/tpm_tis.c:90: error: dereferencing pointer to incomplete type
>
> Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
> Cc: Leendert van Doorn <leendert@watson.ibm.com>
> ---
> drivers/char/tpm/tpm_tis.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
FYI, this build breakage is now upstream as well and triggers easily.
This fix was sent 5+ days ago (with still no reply to it), a day
after this fix the security tree pull request was sent with this
known build breakage included, so the bug is still unfixed upstream
and no fix is in the pipeline AFAICS. Got lost?
Thanks,
Ingo
next prev parent reply other threads:[~2011-08-03 18:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-27 4:11 linux-next: Tree for July 27 Stephen Rothwell
2011-07-27 16:27 ` [patch] Re: linux-next: Tree for July 27 (misc/pti) Randy Dunlap
2011-07-27 18:54 ` J Freyensee
2011-07-27 16:41 ` linux-next: Tree for July 27 (watchdog/hpwdt) Randy Dunlap
2011-07-27 19:39 ` Wim Van Sebroeck
2011-07-27 17:11 ` [PATCH -next] firmware: fix google/gsmi.c build warning Randy Dunlap
2011-07-27 19:49 ` Mike Waychison
2011-07-27 18:42 ` [PATCH -next] tpm_tis: fix build when ACPI is not enabled Randy Dunlap
2011-08-03 18:56 ` Ingo Molnar [this message]
2011-08-04 1:34 ` James Morris
[not found] ` <20110727104716.dda819dc.rdunlap@xenotime.net>
2011-07-27 20:11 ` linux-next: Tree for July 27 (iscsi_target) [resend/lost] Nicholas A. Bellinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110803185634.GA16988@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=jmorris@namei.org \
--cc=leendert@watson.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=rdunlap@xenotime.net \
--cc=sfr@canb.auug.org.au \
--cc=torvalds@linux-foundation.org \
--cc=tpmdd-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).