From: Ingo Molnar <mingo@elte.hu>
To: Randy Dunlap <rdunlap@xenotime.net>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
xen-devel@lists.xensource.com,
virtualization@lists.linux-foundation.org,
linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
"H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: linux-next: Tree for July 25 (xen)
Date: Thu, 4 Aug 2011 21:35:34 +0200 [thread overview]
Message-ID: <20110804193534.GB12729@elte.hu> (raw)
In-Reply-To: <20110725144629.b752bf14.rdunlap@xenotime.net>
* Randy Dunlap <rdunlap@xenotime.net> wrote:
> On Mon, 25 Jul 2011 16:25:42 +1000 Stephen Rothwell wrote:
>
> > Hi all,
>
> xen has lots of build errors and warnings (all on x86_64).
>
> CC arch/x86/xen/setup.o
> In file included from arch/x86/include/asm/xen/hypercall.h:42,
> from arch/x86/xen/setup.c:19:
> include/trace/events/xen.h:31: warning: 'struct multicall_entry' declared inside parameter list
> include/trace/events/xen.h:31: warning: its scope is only this definition or declaration, which is probably not what you want
> include/trace/events/xen.h:31: warning: 'struct multicall_entry' declared inside parameter list
> include/trace/events/xen.h:31: warning: 'struct multicall_entry' declared inside parameter list
> include/trace/events/xen.h:31: warning: 'struct multicall_entry' declared inside parameter list
> In file included from arch/x86/xen/setup.c:19:
> arch/x86/include/asm/xen/hypercall.h: In function 'MULTI_fpu_taskswitch':
> arch/x86/include/asm/xen/hypercall.h:465: warning: passing argument 1 of 'trace_xen_mc_entry' from incompatible pointer type
> include/trace/events/xen.h:48: note: expected 'struct multicall_entry *' but argument is of type 'struct multicall_entry *'
> arch/x86/include/asm/xen/hypercall.h: In function 'MULTI_update_va_mapping':
> arch/x86/include/asm/xen/hypercall.h:483: warning: passing argument 1 of 'trace_xen_mc_entry' from incompatible pointer type
> include/trace/events/xen.h:48: note: expected 'struct multicall_entry *' but argument is of type 'struct multicall_entry *'
> arch/x86/include/asm/xen/hypercall.h: In function 'MULTI_grant_table_op':
> arch/x86/include/asm/xen/hypercall.h:495: warning: passing argument 1 of 'trace_xen_mc_entry' from incompatible pointer type
> include/trace/events/xen.h:48: note: expected 'struct multicall_entry *' but argument is of type 'struct multicall_entry *'
> arch/x86/include/asm/xen/hypercall.h: In function 'MULTI_update_va_mapping_otherdomain':
> arch/x86/include/asm/xen/hypercall.h:516: warning: passing argument 1 of 'trace_xen_mc_entry' from incompatible pointer type
> include/trace/events/xen.h:48: note: expected 'struct multicall_entry *' but argument is of type 'struct multicall_entry *'
> arch/x86/include/asm/xen/hypercall.h: In function 'MULTI_update_descriptor':
> arch/x86/include/asm/xen/hypercall.h:534: warning: passing argument 1 of 'trace_xen_mc_entry' from incompatible pointer type
> include/trace/events/xen.h:48: note: expected 'struct multicall_entry *' but argument is of type 'struct multicall_entry *'
> arch/x86/include/asm/xen/hypercall.h: In function 'MULTI_memory_op':
> arch/x86/include/asm/xen/hypercall.h:544: warning: passing argument 1 of 'trace_xen_mc_entry' from incompatible pointer type
> include/trace/events/xen.h:48: note: expected 'struct multicall_entry *' but argument is of type 'struct multicall_entry *'
> arch/x86/include/asm/xen/hypercall.h: In function 'MULTI_mmu_update':
> arch/x86/include/asm/xen/hypercall.h:557: warning: passing argument 1 of 'trace_xen_mc_entry' from incompatible pointer type
> include/trace/events/xen.h:48: note: expected 'struct multicall_entry *' but argument is of type 'struct multicall_entry *'
> arch/x86/include/asm/xen/hypercall.h: In function 'MULTI_mmuext_op':
> arch/x86/include/asm/xen/hypercall.h:570: warning: passing argument 1 of 'trace_xen_mc_entry' from incompatible pointer type
> include/trace/events/xen.h:48: note: expected 'struct multicall_entry *' but argument is of type 'struct multicall_entry *'
> arch/x86/include/asm/xen/hypercall.h: In function 'MULTI_set_gdt':
> arch/x86/include/asm/xen/hypercall.h:580: warning: passing argument 1 of 'trace_xen_mc_entry' from incompatible pointer type
> include/trace/events/xen.h:48: note: expected 'struct multicall_entry *' but argument is of type 'struct multicall_entry *'
> arch/x86/include/asm/xen/hypercall.h: In function 'MULTI_stack_switch':
> arch/x86/include/asm/xen/hypercall.h:591: warning: passing argument 1 of 'trace_xen_mc_entry' from incompatible pointer type
> include/trace/events/xen.h:48: note: expected 'struct multicall_entry *' but argument is of type 'struct multicall_entry *'
> CC arch/x86/xen/multicalls.o
> In file included from arch/x86/include/asm/xen/hypercall.h:42,
> from arch/x86/xen/multicalls.c:26:
> include/trace/events/xen.h:31: warning: 'struct multicall_entry' declared inside parameter list
> include/trace/events/xen.h:31: warning: its scope is only this definition or declaration, which is probably not what you want
> include/trace/events/xen.h:31: warning: 'struct multicall_entry' declared inside parameter list
> include/trace/events/xen.h:31: warning: 'struct multicall_entry' declared inside parameter list
> include/trace/events/xen.h:31: warning: 'struct multicall_entry' declared inside parameter list
These build failures are still triggering upstream:
arch/x86/xen/trace.c:44:2: error: array index in initializer not of integer type
arch/x86/xen/trace.c:44:2: error: (near initialization for ‘xen_hypercall_names’)
arch/x86/xen/trace.c:45:1: error: ‘__HYPERVISOR_arch_4’ undeclared here (not in a function)
arch/x86/xen/trace.c:45:2: error: array index in initializer not of integer type
arch/x86/xen/trace.c:45:2: error: (near initialization for ‘xen_hypercall_names’)
even after:
b3c4b9825075: xen/tracing: fix compile errors when tracing is disabled.
Btw., that the heck is going on with the commit that introduced the
build failure:
commit bd9ddc875b6659f9f74dcfd285c472bc58041abd
Author: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
AuthorDate: Mon Jun 20 17:52:13 2011 -0700
Commit: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
CommitDate: Mon Jul 18 15:43:46 2011 -0700
It was apparently rebased shortly before the merge window and sent to
Linus 3 days later, with little to no linux-next testing ...
I'm absolutely unhappy about how the Xen tree is being run. It's
using a sloppy, crappy workflow and it is producing crap.
Thanks,
Ingo
next prev parent reply other threads:[~2011-08-04 19:36 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-25 6:25 linux-next: Tree for July 25 Stephen Rothwell
2011-07-25 16:19 ` [PATCH -next] watchdog: fix it8712f_wdt build errors Randy Dunlap
2011-07-25 19:02 ` Wim Van Sebroeck
2011-07-25 18:01 ` [PATCH -next] kvm: fix TASK_DELAY_ACCT kconfig warning Randy Dunlap
2011-07-27 11:19 ` Avi Kivity
2011-07-25 21:46 ` linux-next: Tree for July 25 (xen) Randy Dunlap
2011-08-04 19:35 ` Ingo Molnar [this message]
2011-08-04 19:55 ` [Xen-devel] " Konrad Rzeszutek Wilk
2011-08-04 20:15 ` Randy Dunlap
2011-08-04 22:30 ` [Xen-devel] " Konrad Rzeszutek Wilk
2011-08-04 23:22 ` Randy Dunlap
2011-08-04 22:32 ` Konrad Rzeszutek Wilk
2011-08-04 22:40 ` Konrad Rzeszutek Wilk
2011-08-04 23:24 ` Randy Dunlap
2011-08-04 23:53 ` Randy Dunlap
2011-08-05 8:05 ` Ingo Molnar
2011-08-05 21:14 ` Ingo Molnar
2011-08-06 1:58 ` Konrad Rzeszutek Wilk
2011-08-06 7:04 ` Stephen Rothwell
2011-08-06 18:22 ` Jeremy Fitzhardinge
2011-08-08 13:01 ` Steven Rostedt
2011-08-10 16:49 ` Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110804193534.GB12729@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=jeremy.fitzhardinge@citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=rdunlap@xenotime.net \
--cc=sfr@canb.auug.org.au \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).