From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: linux-next: build warning after merge of the moduleh tree
Date: Thu, 18 Aug 2011 22:57:44 +0200 [thread overview]
Message-ID: <201108182257.44926.rjw@sisk.pl> (raw)
In-Reply-To: <20110818192754.972382bbed8fa3adc6dca9c5@canb.auug.org.au>
On Thursday, August 18, 2011, Stephen Rothwell wrote:
> Hi Rafael,
>
> On Thu, 18 Aug 2011 10:26:51 +0200 "Rafael J. Wysocki" <rjw@sisk.pl> wrote:
> >
> > Do you mean that drivers/base/power/common.c should include module.h
> > or something else?
>
> Yes, that is exactly what I mean :-) See Rule 1 in
> Documentation/SubmitChecklist. The reason it is different, is because
> the module.h splitup is cerating export.h for files that just need
> EXPORT_SYMBOL (like this file).
OK, I've modified common.c so that module.h is included.
Thanks,
Rafael
next prev parent reply other threads:[~2011-08-18 20:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-18 5:09 linux-next: build warning after merge of the moduleh tree Stephen Rothwell
2011-08-18 8:26 ` Rafael J. Wysocki
2011-08-18 9:27 ` Stephen Rothwell
2011-08-18 20:57 ` Rafael J. Wysocki [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-10-11 9:21 Stephen Rothwell
2011-10-11 13:16 ` Paul Gortmaker
2011-09-28 7:18 Stephen Rothwell
2011-09-28 7:39 ` Pihet-XID, Jean
2011-08-01 3:23 Stephen Rothwell
2011-08-02 7:26 ` Jens Axboe
2011-08-02 8:35 ` Stephen Rothwell
2011-08-02 8:42 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201108182257.44926.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).