From: Greg KH <greg@kroah.com>
To: Timur Tabi <timur@freescale.com>
Cc: sfr@canb.auug.org.au, linux-next@vger.kernel.org,
linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] tty/powerpc: fix build break with ehv_bytechan.c on allyesconfig
Date: Thu, 25 Aug 2011 11:46:55 -0700 [thread overview]
Message-ID: <20110825184655.GB1891@kroah.com> (raw)
In-Reply-To: <4E568E19.405@freescale.com>
On Thu, Aug 25, 2011 at 01:02:01PM -0500, Timur Tabi wrote:
> Greg KH wrote:
> > tested doesn't mean that it shouldn't still build properly for other
> > platforms, right?
>
> The problem is the dependency on MSR_GS, which is defined only for Book-E
> PowerPC chips, not all PowerPC.
>
> So I gave it some more thought, and technically ePAPR extends beyond Book-E, so
> it's wrong for the driver to depend on anything specific to Book-E. I've
> removed the code that breaks:
>
> /* Check if we're running as a guest of a hypervisor */
> if (!(mfmsr() & MSR_GS))
> return;
But don't you really want this type of check at runtime? What happens
if you load this driver on a machine that is not a guest? Will things
break? Shouldn't you still refuse to load somehow?
thanks,
greg k-h
next prev parent reply other threads:[~2011-08-25 18:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-25 16:20 [PATCH] tty/powerpc: fix build break with ehv_bytechan.c on allyesconfig Timur Tabi
2011-08-25 16:32 ` Greg KH
2011-08-25 18:02 ` Timur Tabi
2011-08-25 18:46 ` Greg KH [this message]
2011-08-25 18:51 ` Timur Tabi
2011-08-25 19:03 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110825184655.GB1891@kroah.com \
--to=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=sfr@canb.auug.org.au \
--cc=timur@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).