* [PATCH -next] seeq: fix compile breakage on s390
@ 2011-09-22 7:17 Heiko Carstens
2011-09-22 7:29 ` Jeff Kirsher
0 siblings, 1 reply; 4+ messages in thread
From: Heiko Carstens @ 2011-09-22 7:17 UTC (permalink / raw)
To: Jeff Kirsher; +Cc: linux-next, Heiko Carstens
The SEEQ drivers should depend on HAS_IOMEM to prevent compile breakage
on !HAS_IOMEM architectures:
drivers/net/ethernet/seeq/seeq8005.c: In function 'seeq8005_probe1':
drivers/net/ethernet/seeq/seeq8005.c:179:2: error:
implicit declaration of function 'inw' [-Werror=implicit-function-declaration]
Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
---
drivers/net/ethernet/seeq/Kconfig | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/net/ethernet/seeq/Kconfig b/drivers/net/ethernet/seeq/Kconfig
index 49b6d5b..29f1853 100644
--- a/drivers/net/ethernet/seeq/Kconfig
+++ b/drivers/net/ethernet/seeq/Kconfig
@@ -5,6 +5,7 @@
config NET_VENDOR_SEEQ
bool "SEEQ devices"
default y
+ depends on HAS_IOMEM
depends on (ARM && ARCH_ACORN) || SGI_HAS_SEEQ || EXPERIMENTAL
---help---
If you have a network (Ethernet) card belonging to this class, say Y
--
1.7.5.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH -next] seeq: fix compile breakage on s390
2011-09-22 7:17 Heiko Carstens
@ 2011-09-22 7:29 ` Jeff Kirsher
0 siblings, 0 replies; 4+ messages in thread
From: Jeff Kirsher @ 2011-09-22 7:29 UTC (permalink / raw)
To: Heiko Carstens; +Cc: linux-next@vger.kernel.org
[-- Attachment #1: Type: text/plain, Size: 545 bytes --]
On Thu, 2011-09-22 at 00:17 -0700, Heiko Carstens wrote:
>
> The SEEQ drivers should depend on HAS_IOMEM to prevent compile
> breakage
> on !HAS_IOMEM architectures:
>
> drivers/net/ethernet/seeq/seeq8005.c: In function 'seeq8005_probe1':
> drivers/net/ethernet/seeq/seeq8005.c:179:2: error:
> implicit declaration of function
> 'inw' [-Werror=implicit-function-declaration]
>
> Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
You need to send this to netdev@vger.kernel.org for David Miller to pick
this fix up.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH -next] seeq: fix compile breakage on s390
@ 2011-09-22 7:42 Heiko Carstens
2011-09-22 7:50 ` David Miller
0 siblings, 1 reply; 4+ messages in thread
From: Heiko Carstens @ 2011-09-22 7:42 UTC (permalink / raw)
To: David Miller; +Cc: netdev, linux-next, Heiko Carstens, Jeff Kirsher
The SEEQ drivers should depend on HAS_IOMEM to prevent compile breakage
on !HAS_IOMEM architectures:
drivers/net/ethernet/seeq/seeq8005.c: In function 'seeq8005_probe1':
drivers/net/ethernet/seeq/seeq8005.c:179:2: error:
implicit declaration of function 'inw' [-Werror=implicit-function-declaration]
Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
---
drivers/net/ethernet/seeq/Kconfig | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/net/ethernet/seeq/Kconfig b/drivers/net/ethernet/seeq/Kconfig
index 49b6d5b..29f1853 100644
--- a/drivers/net/ethernet/seeq/Kconfig
+++ b/drivers/net/ethernet/seeq/Kconfig
@@ -5,6 +5,7 @@
config NET_VENDOR_SEEQ
bool "SEEQ devices"
default y
+ depends on HAS_IOMEM
depends on (ARM && ARCH_ACORN) || SGI_HAS_SEEQ || EXPERIMENTAL
---help---
If you have a network (Ethernet) card belonging to this class, say Y
--
1.7.5.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH -next] seeq: fix compile breakage on s390
2011-09-22 7:42 [PATCH -next] seeq: fix compile breakage on s390 Heiko Carstens
@ 2011-09-22 7:50 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2011-09-22 7:50 UTC (permalink / raw)
To: heiko.carstens; +Cc: netdev, linux-next, jeffrey.t.kirsher
From: Heiko Carstens <heiko.carstens@de.ibm.com>
Date: Thu, 22 Sep 2011 09:42:06 +0200
> The SEEQ drivers should depend on HAS_IOMEM to prevent compile breakage
> on !HAS_IOMEM architectures:
>
> drivers/net/ethernet/seeq/seeq8005.c: In function 'seeq8005_probe1':
> drivers/net/ethernet/seeq/seeq8005.c:179:2: error:
> implicit declaration of function 'inw' [-Werror=implicit-function-declaration]
>
> Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-09-22 7:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-09-22 7:42 [PATCH -next] seeq: fix compile breakage on s390 Heiko Carstens
2011-09-22 7:50 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2011-09-22 7:17 Heiko Carstens
2011-09-22 7:29 ` Jeff Kirsher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).