From: Samuel Ortiz <sameo@linux.intel.com>
To: Jin Park <jinyoungp@nvidia.com>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>,
linux-next@vger.kernel.org
Subject: Re: linux-next: build failure in drivers/mfd/aat2870-core.c
Date: Tue, 4 Oct 2011 12:37:51 +0200 [thread overview]
Message-ID: <20111004103751.GX4118@sortiz-mobl> (raw)
In-Reply-To: <CAMfhKb9dTY_OemQAgJokHn=DzaHn2hpi8UHRGvtFOv7a0SEjkg@mail.gmail.com>
Hi Jin,
On Fri, Sep 30, 2011 at 08:47:41PM +0900, Jin Park wrote:
> Hi, Paul
>
> I have checked aat2870-core.c build problem when x86_64 and got the
> same error with you.
>
> This error occurred since merged below change.
> ----------------------------------------------------------------------------------
> commit da417bacc9143b934f1a480a25d0fb2bb648a820
> Author: Stephen Boyd <sboyd@codeaurora.org>
> Date: Wed Sep 28 10:50:29 2011 +1000
>
> x86: implement strict user copy checks for x86_64
> ----------------------------------------------------------------------------------
> The above change is check object size and copy size for
> copy_from_user() to prevent overflow.
>
> The root cause is not matched type of size parameter for
> copy_from_user() in aat2870-core.c for x86_64.
> Because I just passed int type for size parameter to copy_from_user().
> It has no problem for i386, but has problem for x86_64.
>
>
> This is the patch for this build problem. Please review it.
I applied this patch and fixed the changelog to be slightly more descriptive.
Thanks a lot for the fix.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
prev parent reply other threads:[~2011-10-04 10:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-28 22:10 linux-next: build failure in drivers/mfd/aat2870-core.c Paul Gortmaker
[not found] ` <D9A2FA38A1E15B4E832469E5FE40C7ABFA07D3E667@HKMAIL01.nvidia.com>
2011-09-30 11:47 ` Jin Park
2011-09-30 15:46 ` Paul Gortmaker
2011-10-04 10:37 ` Samuel Ortiz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111004103751.GX4118@sortiz-mobl \
--to=sameo@linux.intel.com \
--cc=jinyoungp@nvidia.com \
--cc=linux-next@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).