From: Felipe Balbi <balbi@ti.com>
To: Randy Dunlap <rdunlap@xenotime.net>
Cc: balbi@ti.com, Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
linux-usb@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH -next] usb gadget: fix langwell_udc.c build error
Date: Mon, 10 Oct 2011 01:36:40 +0300 [thread overview]
Message-ID: <20111009223638.GA29776@legolas.emea.dhcp.ti.com> (raw)
In-Reply-To: <4E91DF00.8060107@xenotime.net>
[-- Attachment #1: Type: text/plain, Size: 1490 bytes --]
Hi,
On Sun, Oct 09, 2011 at 10:50:56AM -0700, Randy Dunlap wrote:
> On 10/08/11 03:03, Felipe Balbi wrote:
> > Hi,
> >
> > On Fri, Oct 07, 2011 at 01:57:42PM -0700, Randy Dunlap wrote:
> >> From: Randy Dunlap <rdunlap@xenotime.net>
> >>
> >> Move function to fix langwell_udc.c build error:
> >>
> >> drivers/usb/gadget/langwell_udc.c: In function 'show_langwell_udc':
> >> drivers/usb/gadget/langwell_udc.c:1693:3: error: implicit declaration of function 'lpm_device_speed'
> >> drivers/usb/gadget/langwell_udc.c: At top level:
> >> drivers/usb/gadget/langwell_udc.c:2637:37: error: conflicting types for 'lpm_device_speed'
> >> drivers/usb/gadget/langwell_udc.c:1693:20: note: previous implicit declaration of 'lpm_device_speed' was here
> >
> > I don't have this compile error on my branch, did something go in
> > without me noticing ?
>
> probably not. What version of gcc are you using?
I believe it did, I don't have lpm_device_speed() at all.
> I'm using 4.5.1.
4.6.1
> > Can you blame a comit which introduced this ?
>
> I don't see such a commit.
$ git log --pretty=oneline -S'lpm_device_speed' HEAD -- \
drivers/usb/gadget/langwell_udc.c
what's the output ?
> > btw, all I have is a warning.
>
> What warning?
drivers/usb/gadget/langwell_udc.c: In function ‘langwell_ep_dequeue’:
drivers/usb/gadget/langwell_udc.c:919:11: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
next prev parent reply other threads:[~2011-10-09 22:36 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-07 6:42 linux-next: Tree for Oct 7 Stephen Rothwell
[not found] ` <20111007174230.702f4a0bf1fe71dab5e10961-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>
2011-10-07 20:57 ` [PATCH -next] usb gadget: fix langwell_udc.c build error Randy Dunlap
2011-10-08 10:03 ` Felipe Balbi
2011-10-09 17:50 ` Randy Dunlap
2011-10-09 22:36 ` Felipe Balbi [this message]
2011-10-09 23:05 ` Randy Dunlap
[not found] ` <4E9228CA.1060904-/UHa2rfvQTnk1uMJSBkQmQ@public.gmane.org>
2011-10-10 5:10 ` Felipe Balbi
2011-10-10 17:16 ` Greg KH
2011-10-10 17:40 ` Randy Dunlap
2011-10-09 23:33 ` Stephen Rothwell
2011-10-07 20:59 ` [PATCH -next] infiniband: fix ipath_chip_init.c build errors Randy Dunlap
[not found] ` <4E8F683D.9020604-/UHa2rfvQTnk1uMJSBkQmQ@public.gmane.org>
2011-10-07 21:21 ` Roland Dreier
2011-10-07 22:05 ` Randy Dunlap
[not found] ` <4E8F77B8.3000805-/UHa2rfvQTnk1uMJSBkQmQ@public.gmane.org>
2011-10-07 23:28 ` Stephen Rothwell
2011-10-10 19:02 ` Roland Dreier
2011-10-11 0:33 ` Stephen Rothwell
2011-10-10 18:57 ` Mike Marciniszyn
2011-10-10 19:02 ` Randy Dunlap
2011-10-11 13:06 ` Mike Marciniszyn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111009223638.GA29776@legolas.emea.dhcp.ti.com \
--to=balbi@ti.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=rdunlap@xenotime.net \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox