From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anders Larsen Subject: [PATCH -next] qnx4fs: Use kmemdup rather than duplicating its implementation Date: Sun, 13 Nov 2011 18:47:49 +0100 Message-ID: <201111131847.49842.al@alarsen.net> Mime-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Return-path: Received: from de01.mail.all-tld.net ([195.140.232.8]:59292 "EHLO de01.mail.all-tld.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752643Ab1KMSTS (ORCPT ); Sun, 13 Nov 2011 13:19:18 -0500 Sender: linux-next-owner@vger.kernel.org List-ID: To: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Thomas Meyer From: Thomas Meyer Use kmemdup rather than duplicating its implementation The semantic patch that makes this change is available in scripts/coccinelle/api/memdup.cocci. Signed-off-by: Thomas Meyer Signed-off-by: Anders Larsen --- diff -u -p a/fs/qnx4/inode.c b/fs/qnx4/inode.c --- a/fs/qnx4/inode.c 2011-11-07 19:38:23.987165894 +0100 +++ b/fs/qnx4/inode.c 2011-11-08 10:33:59.882543999 +0100 @@ -199,12 +199,13 @@ static const char *qnx4_checkroot(struct if (!strcmp(rootdir->di_fname, QNX4_BMNAME)) { found = 1; - qnx4_sb(sb)->BitMap = kmalloc( sizeof( struct qnx4_inode_entry ), GFP_KERNEL ); + qnx4_sb(sb)->BitMap = kmemdup(rootdir, + sizeof(struct qnx4_inode_entry), + GFP_KERNEL); if (!qnx4_sb(sb)->BitMap) { brelse (bh); return "not enough memory for bitmap inode"; - } - memcpy( qnx4_sb(sb)->BitMap, rootdir, sizeof( struct qnx4_inode_entry ) ); /* keep bitmap inode known */ + }/* keep bitmap inode known */ break; } }