[PATCH] mm: Fix alloc_vm_area for noMMU system

[PATCH] mm: Fix alloc_vm_area for noMMU system

[Michal Simek]

Patch:
"xen: map foreign pages for shared rings by updating the PTEs directly"
(sha1: 5149c0d53f6959d6ab87b4702d544b17ebdc783e) changed number
of argument for alloc_vm_area but forget to change it for noMMU systems.
This patch fix it.

CC: David Vrabel <david.vrabel@citrix.com>
CC: Andrew Morton <akpm@linux-foundation.org>
CC: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Signed-off-by: Michal Simek <monstr@monstr.eu>

---
It is for linux-next tree.

Michal
---
 mm/nommu.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/mm/nommu.c b/mm/nommu.c
index 73419c5..b982290 100644
--- a/mm/nommu.c
+++ b/mm/nommu.c
@@ -454,7 +454,7 @@ void  __attribute__((weak)) vmalloc_sync_all(void)
  *	between processes, it syncs the pagetable across all
  *	processes.
  */
-struct vm_struct *alloc_vm_area(size_t size)
+struct vm_struct *alloc_vm_area(size_t size, pte_t **ptes)
 {
 	BUG();
 	return NULL;
-- 
1.7.5.4

Re: [PATCH] mm: Fix alloc_vm_area for noMMU system

[Konrad Rzeszutek Wilk]

On Wed, Nov 16, 2011 at 08:51:02AM +0100, Michal Simek wrote:
> Patch:
> "xen: map foreign pages for shared rings by updating the PTEs directly"
> (sha1: 5149c0d53f6959d6ab87b4702d544b17ebdc783e) changed number
> of argument for alloc_vm_area but forget to change it for noMMU systems.
> This patch fix it.

Duh!
> 
> CC: David Vrabel <david.vrabel@citrix.com>
> CC: Andrew Morton <akpm@linux-foundation.org>
> CC: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>

Yes, please. Thank you!

> Signed-off-by: Michal Simek <monstr@monstr.eu>
> 
> ---
> It is for linux-next tree.
> 
> Michal
> ---
>  mm/nommu.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/mm/nommu.c b/mm/nommu.c
> index 73419c5..b982290 100644
> --- a/mm/nommu.c
> +++ b/mm/nommu.c
> @@ -454,7 +454,7 @@ void  __attribute__((weak)) vmalloc_sync_all(void)
>   *	between processes, it syncs the pagetable across all
>   *	processes.
>   */
> -struct vm_struct *alloc_vm_area(size_t size)
> +struct vm_struct *alloc_vm_area(size_t size, pte_t **ptes)
>  {
>  	BUG();
>  	return NULL;
> -- 
> 1.7.5.4

Re: [PATCH] mm: Fix alloc_vm_area for noMMU system

[David Vrabel]

On 16/11/11 13:59, Konrad Rzeszutek Wilk wrote:
> On Wed, Nov 16, 2011 at 08:51:02AM +0100, Michal Simek wrote:
>> Patch:
>> "xen: map foreign pages for shared rings by updating the PTEs directly"
>> (sha1: 5149c0d53f6959d6ab87b4702d544b17ebdc783e) changed number
>> of argument for alloc_vm_area but forget to change it for noMMU systems.
>> This patch fix it.
> 
> Duh!
>>
>> CC: David Vrabel <david.vrabel@citrix.com>
>> CC: Andrew Morton <akpm@linux-foundation.org>
>> CC: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> 
> Yes, please. Thank you!

Konrad, I would suggest folding this into the original patch to avoid
breaking bisects for noMMU users unnecessarily.

David

>> Signed-off-by: Michal Simek <monstr@monstr.eu>
>>
>> ---
>> It is for linux-next tree.
>>
>> Michal
>> ---
>>  mm/nommu.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/mm/nommu.c b/mm/nommu.c
>> index 73419c5..b982290 100644
>> --- a/mm/nommu.c
>> +++ b/mm/nommu.c
>> @@ -454,7 +454,7 @@ void  __attribute__((weak)) vmalloc_sync_all(void)
>>   *	between processes, it syncs the pagetable across all
>>   *	processes.
>>   */
>> -struct vm_struct *alloc_vm_area(size_t size)
>> +struct vm_struct *alloc_vm_area(size_t size, pte_t **ptes)
>>  {
>>  	BUG();
>>  	return NULL;
>> -- 
>> 1.7.5.4

Re: [PATCH] mm: Fix alloc_vm_area for noMMU system

[Konrad Rzeszutek Wilk]

On Wed, Nov 16, 2011 at 02:01:28PM +0000, David Vrabel wrote:
> On 16/11/11 13:59, Konrad Rzeszutek Wilk wrote:
> > On Wed, Nov 16, 2011 at 08:51:02AM +0100, Michal Simek wrote:
> >> Patch:
> >> "xen: map foreign pages for shared rings by updating the PTEs directly"
> >> (sha1: 5149c0d53f6959d6ab87b4702d544b17ebdc783e) changed number
> >> of argument for alloc_vm_area but forget to change it for noMMU systems.
> >> This patch fix it.
> > 
> > Duh!
> >>
> >> CC: David Vrabel <david.vrabel@citrix.com>
> >> CC: Andrew Morton <akpm@linux-foundation.org>
> >> CC: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> > 
> > Yes, please. Thank you!
> 
> Konrad, I would suggest folding this into the original patch to avoid
> breaking bisects for noMMU users unnecessarily.

Can't do. We would lose Michal authership that way and that is not good.

> 
> David
> 
> >> Signed-off-by: Michal Simek <monstr@monstr.eu>
> >>
> >> ---
> >> It is for linux-next tree.
> >>
> >> Michal
> >> ---
> >>  mm/nommu.c |    2 +-
> >>  1 files changed, 1 insertions(+), 1 deletions(-)
> >>
> >> diff --git a/mm/nommu.c b/mm/nommu.c
> >> index 73419c5..b982290 100644
> >> --- a/mm/nommu.c
> >> +++ b/mm/nommu.c
> >> @@ -454,7 +454,7 @@ void  __attribute__((weak)) vmalloc_sync_all(void)
> >>   *	between processes, it syncs the pagetable across all
> >>   *	processes.
> >>   */
> >> -struct vm_struct *alloc_vm_area(size_t size)
> >> +struct vm_struct *alloc_vm_area(size_t size, pte_t **ptes)
> >>  {
> >>  	BUG();
> >>  	return NULL;
> >> -- 
> >> 1.7.5.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-next" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] mm: Fix alloc_vm_area for noMMU system

[Michal Simek]

Konrad Rzeszutek Wilk wrote:
> On Wed, Nov 16, 2011 at 02:01:28PM +0000, David Vrabel wrote:
>> On 16/11/11 13:59, Konrad Rzeszutek Wilk wrote:
>>> On Wed, Nov 16, 2011 at 08:51:02AM +0100, Michal Simek wrote:
>>>> Patch:
>>>> "xen: map foreign pages for shared rings by updating the PTEs directly"
>>>> (sha1: 5149c0d53f6959d6ab87b4702d544b17ebdc783e) changed number
>>>> of argument for alloc_vm_area but forget to change it for noMMU systems.
>>>> This patch fix it.
>>> Duh!
>>>> CC: David Vrabel <david.vrabel@citrix.com>
>>>> CC: Andrew Morton <akpm@linux-foundation.org>
>>>> CC: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
>>> Yes, please. Thank you!
>> Konrad, I would suggest folding this into the original patch to avoid
>> breaking bisects for noMMU users unnecessarily.
> 
> Can't do. We would lose Michal authership that way and that is not good.
> 

Do it in way you like and it is the best for others. Not sure where exactly your patch
is and it is hard to suggest you how to do it in connection to your merging strategy
Anyway you can add my signed-off-by line to origin patch or keep it single patch

Thanks,
Michal


-- 
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/
Microblaze U-BOOT custodian

Re: [PATCH] mm: Fix alloc_vm_area for noMMU system

[Konrad Rzeszutek Wilk]

On Wed, Nov 16, 2011 at 03:25:30PM +0100, Michal Simek wrote:
> Konrad Rzeszutek Wilk wrote:
> >On Wed, Nov 16, 2011 at 02:01:28PM +0000, David Vrabel wrote:
> >>On 16/11/11 13:59, Konrad Rzeszutek Wilk wrote:
> >>>On Wed, Nov 16, 2011 at 08:51:02AM +0100, Michal Simek wrote:
> >>>>Patch:
> >>>>"xen: map foreign pages for shared rings by updating the PTEs directly"
> >>>>(sha1: 5149c0d53f6959d6ab87b4702d544b17ebdc783e) changed number
> >>>>of argument for alloc_vm_area but forget to change it for noMMU systems.
> >>>>This patch fix it.
> >>>Duh!
> >>>>CC: David Vrabel <david.vrabel@citrix.com>
> >>>>CC: Andrew Morton <akpm@linux-foundation.org>
> >>>>CC: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> >>>Yes, please. Thank you!
> >>Konrad, I would suggest folding this into the original patch to avoid
> >>breaking bisects for noMMU users unnecessarily.
> >
> >Can't do. We would lose Michal authership that way and that is not good.
> >
> 
> Do it in way you like and it is the best for others. Not sure where exactly your patch

That is very nice of you!

> is and it is hard to suggest you how to do it in connection to your merging strategy
> Anyway you can add my signed-off-by line to origin patch or keep it single patch

Ok. That certainly makes it easier and it does not break the git bisection.

Will do! Thank you.

Re: [PATCH] mm: Fix alloc_vm_area for noMMU system

[Konrad Rzeszutek Wilk]

On Wed, Nov 16, 2011 at 08:51:02AM +0100, Michal Simek wrote:
> Patch:
> "xen: map foreign pages for shared rings by updating the PTEs directly"
> (sha1: 5149c0d53f6959d6ab87b4702d544b17ebdc783e) changed number
> of argument for alloc_vm_area but forget to change it for noMMU systems.
> This patch fix it.
> 
> CC: David Vrabel <david.vrabel@citrix.com>
> CC: Andrew Morton <akpm@linux-foundation.org>

Andrew, I was thinking to send that "xen: map foreign pages.." to Linus
at some point.

Is it OK if I have your Ack on this patch and stick this with the
mentioned patch in my queue?

> CC: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> Signed-off-by: Michal Simek <monstr@monstr.eu>
> 
> ---
> It is for linux-next tree.
> 
> Michal
> ---
>  mm/nommu.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/mm/nommu.c b/mm/nommu.c
> index 73419c5..b982290 100644
> --- a/mm/nommu.c
> +++ b/mm/nommu.c
> @@ -454,7 +454,7 @@ void  __attribute__((weak)) vmalloc_sync_all(void)
>   *	between processes, it syncs the pagetable across all
>   *	processes.
>   */
> -struct vm_struct *alloc_vm_area(size_t size)
> +struct vm_struct *alloc_vm_area(size_t size, pte_t **ptes)
>  {
>  	BUG();
>  	return NULL;
> -- 
> 1.7.5.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-next" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html