From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean-Christophe PLAGNIOL-VILLARD Subject: Re: [PATCH] at91_ether: use gpio_is_valid for phy IRQ line Date: Fri, 25 Nov 2011 14:47:08 +0100 Message-ID: <20111125134708.GM15531@game.jcrosoft.org> References: <1322128098-17724-1-git-send-email-jamie@jamieiles.com> <1322169674-4109-1-git-send-email-nicolas.ferre@atmel.com> <20111124222836.GB28582@gallagher> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from 5.mo2.mail-out.ovh.net ([87.98.181.248]:51487 "EHLO mo2.mail-out.ovh.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755414Ab1KYNwP (ORCPT ); Fri, 25 Nov 2011 08:52:15 -0500 Received: from mail190.ha.ovh.net (b7.ovh.net [213.186.33.57]) by mo2.mail-out.ovh.net (Postfix) with SMTP id 344ACDCB523 for ; Fri, 25 Nov 2011 14:58:40 +0100 (CET) Content-Disposition: inline In-Reply-To: <20111124222836.GB28582@gallagher> Sender: linux-next-owner@vger.kernel.org List-ID: To: Jamie Iles Cc: Nicolas Ferre , netdev@vger.kernel.org, sfr@canb.auug.org.au, linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org On 22:28 Thu 24 Nov , Jamie Iles wrote: > Hi Nicolas, > > On Thu, Nov 24, 2011 at 10:21:14PM +0100, Nicolas Ferre wrote: > > Use the generic gpiolib gpio_is_valid() function to test > > if the phy IRQ line GPIO is actually provided. > > > > For non-connected or non-existing phy IRQ lines, -EINVAL > > value is used for phy_irq_pin field of struct at91_eth_data. > > > > Signed-off-by: Nicolas Ferre > > --- > > drivers/net/ethernet/cadence/at91_ether.c | 23 +++++++++++++---------- > > 1 files changed, 13 insertions(+), 10 deletions(-) > > > > diff --git a/drivers/net/ethernet/cadence/at91_ether.c b/drivers/net/ethernet/cadence/at91_ether.c > > index 56624d3..a1c4143 100644 > > --- a/drivers/net/ethernet/cadence/at91_ether.c > > +++ b/drivers/net/ethernet/cadence/at91_ether.c > > @@ -255,8 +255,7 @@ static void enable_phyirq(struct net_device *dev) > > unsigned int dsintr, irq_number; > > int status; > > > > - irq_number = lp->board_data.phy_irq_pin; > > - if (!irq_number) { > > + if (!gpio_is_valid(lp->board_data.phy_irq_pin)) { > > /* > > * PHY doesn't have an IRQ pin (RTL8201, DP83847, AC101L), > > * or board does not have it connected. > > @@ -265,6 +264,7 @@ static void enable_phyirq(struct net_device *dev) > > return; > > } > > > > + irq_number = lp->board_data.phy_irq_pin; > > Does this need to be: > > irq_number = gpio_to_irq(lp->board_data.phy_irq_pin); > > and the same for the other occurrences? Otherwise this looks like the > right thing to me. yes Acked-by: Jean-Christophe PLAGNIOL-VILLARD Best Regards, J.