From: Martin Schwidefsky <schwidefsky@de.ibm.com>
To: Glauber Costa <glommer@parallels.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
"H. Peter Anvin" <hpa@zytor.com>,
Peter Zijlstra <peterz@infradead.org>,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: linux-next: manual merge of the tip tree with the cputime tree
Date: Wed, 7 Dec 2011 12:59:37 +0100 [thread overview]
Message-ID: <20111207125937.4d4adc38@de.ibm.com> (raw)
In-Reply-To: <4EDF4F6D.1040806@parallels.com>
On Wed, 7 Dec 2011 09:35:09 -0200
Glauber Costa <glommer@parallels.com> wrote:
> On 12/07/2011 02:09 AM, Stephen Rothwell wrote:
> > + index = (TASK_NICE(p)> 0) ? CPUTIME_NICE : CPUTIME_USER;
> > +
> > /* Add user time to cpustat. */
> > - if (TASK_NICE(p)> 0)
> > - cpustat->nice += (__force cputime64_t) cputime;
> > - else
> > - cpustat->user += (__force cputime64_t) cputime;
> > - task_group_account_field(p, index, cputime);
> > ++ task_group_account_field(p, index, (__force cputime64_t) cputime);
>
>
> I doubt __force cputime64_t is necessary. After these patches, those
> fields are all u64.
You need the __force keyword whenever a conversion between a cputime[64]_t
and a plain scalar type is done. The cputime[64]_t types are defined with
__nocast so that sparse can find bugs in the usage of cputime.
--
blue skies,
Martin.
"Reality continues to ruin my life." - Calvin.
next prev parent reply other threads:[~2011-12-07 11:59 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-07 4:09 linux-next: manual merge of the tip tree with the cputime tree Stephen Rothwell
2011-12-07 11:35 ` Glauber Costa
2011-12-07 11:59 ` Martin Schwidefsky [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-12-19 4:40 Stephen Rothwell
2011-12-19 8:08 ` Ingo Molnar
2011-12-19 9:11 ` Martin Schwidefsky
2011-12-19 10:35 ` Ingo Molnar
2011-12-19 11:25 ` Ingo Molnar
2011-12-19 14:24 ` Martin Schwidefsky
2011-12-19 16:30 ` Ingo Molnar
2011-12-19 19:06 ` Martin Schwidefsky
2011-12-20 11:09 ` Ingo Molnar
2011-12-19 12:31 ` Martin Schwidefsky
2011-12-19 13:43 ` Glauber Costa
2011-12-19 14:19 ` Martin Schwidefsky
2011-12-19 14:08 ` Peter Zijlstra
2011-12-19 14:25 ` Martin Schwidefsky
2011-12-20 10:19 ` Glauber Costa
2011-10-25 7:44 Stephen Rothwell
2011-10-25 7:40 Stephen Rothwell
2011-10-25 15:29 ` Michal Hocko
2011-10-25 7:35 Stephen Rothwell
2011-10-25 15:28 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111207125937.4d4adc38@de.ibm.com \
--to=schwidefsky@de.ibm.com \
--cc=glommer@parallels.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=sfr@canb.auug.org.au \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).