From: Tony Breeds <tony@bakeyournoodle.com>
To: Michael Neuling <mikey@neuling.org>
Cc: Kyle Moffett <Kyle.D.Moffett@boeing.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
linux-next@vger.kernel.org,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
Michael Ellerman <michaele@au1.ibm.com>,
sfr@canb.auug.org.au
Subject: [PATCH] powerpc: fix compile error with 85xx/p1010rdb.c
Date: Fri, 9 Dec 2011 12:39:55 +1100 [thread overview]
Message-ID: <20111209013955.GD20353@thor.bakeyournoodle.com> (raw)
In-Reply-To: <7679.1323324654@neuling.org>
[-- Attachment #1: Type: text/plain, Size: 1143 bytes --]
Current linux-next compiled with mpc85xx_defconfig causes this:
arch/powerpc/platforms/85xx/p1010rdb.c:41:14: error: 'np' undeclared (first use in this function)
arch/powerpc/platforms/85xx/p1023_rds.c:102:14: error: 'np' undeclared (first use in this function)
Introduced in:
commit 996983b75cebb1bc1c2c545f20336f24ebfa17af
Author: Kyle Moffett <Kyle.D.Moffett@boeing.com>
Date: Fri Dec 2 06:28:02 2011 +0000
powerpc/mpic: Search for open-pic device-tree node if NULL
Signed-off-by: Tony Breeds <tony@bakeyournoodle.com>
---
Mikey already posted a fix for p1023_rds.c. I think this is the last
one.
arch/powerpc/platforms/85xx/p1010rdb.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/platforms/85xx/p1010rdb.c b/arch/powerpc/platforms/85x
index 894f1e8..538bc3f 100644
--- a/arch/powerpc/platforms/85xx/p1010rdb.c
+++ b/arch/powerpc/platforms/85xx/p1010rdb.c
@@ -38,10 +38,8 @@ void __init p1010_rdb_pic_init(void)
0, 256, " OpenPIC ");
BUG_ON(mpic == NULL);
- of_node_put(np);
mpic_init(mpic);
-
}
Yours Tony
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2011-12-09 1:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-08 6:10 [PATCH] powerpc: fix compile error with 85xx/p1023_rds.c Michael Neuling
2011-12-09 1:39 ` Tony Breeds [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111209013955.GD20353@thor.bakeyournoodle.com \
--to=tony@bakeyournoodle.com \
--cc=Kyle.D.Moffett@boeing.com \
--cc=benh@kernel.crashing.org \
--cc=linux-next@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=michaele@au1.ibm.com \
--cc=mikey@neuling.org \
--cc=paulus@samba.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).