linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Grant Likely <grant.likely@secretlab.ca>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
	linux-next <linux-next@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Arnd Bergmann <arnd@arndb.de>,
	Russell King - ARM Linux <linux@arm.linux.org.uk>,
	Thomas Gleixner <tglx@linutronix.de>
Subject: Re: Please add irqdomain branch to linux-next
Date: Wed, 15 Feb 2012 20:31:08 -0700	[thread overview]
Message-ID: <20120216033108.GL25779@ponder.secretlab.ca> (raw)
In-Reply-To: <1329361898.3772.43.camel@pasglop>

On Thu, Feb 16, 2012 at 02:11:38PM +1100, Benjamin Herrenschmidt wrote:
> On Wed, 2012-02-15 at 18:32 -0700, Grant Likely wrote:
> 
> > Only nomap users will care about this, and of those 5, only iseries
> > and ps3 actually change it.  How about I add a max_virq parameter to
> > only be used by the nomap revmap?  That seems to be cleaner than a
> > global setting.  I've crafted a patch and will post it with v5 of the
> > series.
> 
> Right, I don't see an obvious need elsewhere so it could be a flag
> specific to nomap, tho it still needs to be taken into account in the
> main allocation code.
> 
> > For now I'll use numa_node_id() at allocation time.  I'll craft a
> > follow-on patch to change the API since it touches a lot of call
> > sites.
> 
> But which node ? :-)
> 
> I'd rather you add a new API, no need to change the call sites:
> 
> Add foo_node(xxx,node); and have the existing foo() be implemented
> as a static inline calling foo_node(xxx,0); or something like that, then
> I can change the powerpc code to use the later & pass the PCI device
> node (which should be in the pci_controller structure). We can add more
> later.

Okay, fair enough.  Instead of changing the series then, adding the new
api can be the follow on patch.

g.

      reply	other threads:[~2012-02-16  3:31 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-02 21:10 Please add irqdomain branch to linux-next Grant Likely
2012-02-02 23:34 ` Stephen Rothwell
2012-02-06  1:35 ` Benjamin Herrenschmidt
2012-02-06  6:15   ` Grant Likely
2012-02-16  1:32     ` Grant Likely
2012-02-16  3:11       ` Benjamin Herrenschmidt
2012-02-16  3:31         ` Grant Likely [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120216033108.GL25779@ponder.secretlab.ca \
    --to=grant.likely@secretlab.ca \
    --cc=arnd@arndb.de \
    --cc=benh@kernel.crashing.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=sfr@canb.auug.org.au \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).