From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: perex@perex.cz, tiwai@suse.de, timur@freescale.com, lrg@ti.com,
linux-next@vger.kernel.org
Subject: Re: [PATCH] sound: fix trivial build error in mpc5200_dma.c
Date: Mon, 27 Feb 2012 14:59:27 +0000 [thread overview]
Message-ID: <20120227145926.GK3191@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1330204350-386-1-git-send-email-paul.gortmaker@windriver.com>
[-- Attachment #1: Type: text/plain, Size: 491 bytes --]
On Sat, Feb 25, 2012 at 04:12:30PM -0500, Paul Gortmaker wrote:
> Add the obvious header to fix this:
>
> sound/soc/fsl/mpc5200_dma.c:301: error: implicit declaration of function 'DMA_BIT_MASK'
> sound/soc/fsl/mpc5200_dma.c:301: error: initializer element is not constant
Applied, thanks, but this does look like someone updating the headers
needs to be chased as the driver hasn't changed here for years.
Please also try to use changelog headers consistent with the subsystem.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-02-27 14:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-25 21:12 [PATCH] sound: fix trivial build error in mpc5200_dma.c Paul Gortmaker
2012-02-27 14:59 ` Mark Brown [this message]
2012-02-27 21:56 ` Timur Tabi
2012-02-27 23:56 ` Mark Brown
2012-02-28 0:43 ` Paul Gortmaker
2012-02-28 10:27 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120227145926.GK3191@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=linux-next@vger.kernel.org \
--cc=lrg@ti.com \
--cc=paul.gortmaker@windriver.com \
--cc=perex@perex.cz \
--cc=timur@freescale.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).