* [PATCH] sound: fix trivial build error in mpc5200_dma.c
@ 2012-02-25 21:12 Paul Gortmaker
2012-02-27 14:59 ` Mark Brown
0 siblings, 1 reply; 6+ messages in thread
From: Paul Gortmaker @ 2012-02-25 21:12 UTC (permalink / raw)
To: perex, tiwai; +Cc: timur, broonie, lrg, linux-next, Paul Gortmaker
Add the obvious header to fix this:
sound/soc/fsl/mpc5200_dma.c:301: error: implicit declaration of function 'DMA_BIT_MASK'
sound/soc/fsl/mpc5200_dma.c:301: error: initializer element is not constant
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
[seen in linux-next-20120224 tree]
diff --git a/sound/soc/fsl/mpc5200_dma.c b/sound/soc/fsl/mpc5200_dma.c
index 33adbf1..9a3f7c5 100644
--- a/sound/soc/fsl/mpc5200_dma.c
+++ b/sound/soc/fsl/mpc5200_dma.c
@@ -8,6 +8,7 @@
#include <linux/module.h>
#include <linux/of_device.h>
+#include <linux/dma-mapping.h>
#include <linux/slab.h>
#include <linux/of_platform.h>
--
1.7.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] sound: fix trivial build error in mpc5200_dma.c
2012-02-25 21:12 [PATCH] sound: fix trivial build error in mpc5200_dma.c Paul Gortmaker
@ 2012-02-27 14:59 ` Mark Brown
2012-02-27 21:56 ` Timur Tabi
0 siblings, 1 reply; 6+ messages in thread
From: Mark Brown @ 2012-02-27 14:59 UTC (permalink / raw)
To: Paul Gortmaker; +Cc: perex, tiwai, timur, lrg, linux-next
[-- Attachment #1: Type: text/plain, Size: 491 bytes --]
On Sat, Feb 25, 2012 at 04:12:30PM -0500, Paul Gortmaker wrote:
> Add the obvious header to fix this:
>
> sound/soc/fsl/mpc5200_dma.c:301: error: implicit declaration of function 'DMA_BIT_MASK'
> sound/soc/fsl/mpc5200_dma.c:301: error: initializer element is not constant
Applied, thanks, but this does look like someone updating the headers
needs to be chased as the driver hasn't changed here for years.
Please also try to use changelog headers consistent with the subsystem.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] sound: fix trivial build error in mpc5200_dma.c
2012-02-27 14:59 ` Mark Brown
@ 2012-02-27 21:56 ` Timur Tabi
2012-02-27 23:56 ` Mark Brown
0 siblings, 1 reply; 6+ messages in thread
From: Timur Tabi @ 2012-02-27 21:56 UTC (permalink / raw)
To: Mark Brown; +Cc: Paul Gortmaker, perex, tiwai, lrg, linux-next
Mark Brown wrote:
> Please also try to use changelog headers consistent with the subsystem.
Can you explain what that means? What are "changelog headers"?
--
Timur Tabi
Linux kernel developer at Freescale
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] sound: fix trivial build error in mpc5200_dma.c
2012-02-27 21:56 ` Timur Tabi
@ 2012-02-27 23:56 ` Mark Brown
2012-02-28 0:43 ` Paul Gortmaker
0 siblings, 1 reply; 6+ messages in thread
From: Mark Brown @ 2012-02-27 23:56 UTC (permalink / raw)
To: Timur Tabi; +Cc: Paul Gortmaker, perex, tiwai, lrg, linux-next
[-- Attachment #1: Type: text/plain, Size: 303 bytes --]
On Mon, Feb 27, 2012 at 03:56:38PM -0600, Timur Tabi wrote:
> Mark Brown wrote:
> > Please also try to use changelog headers consistent with the subsystem.
> Can you explain what that means? What are "changelog headers"?
The first line of the changelog which gets treated specially in various
ways.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] sound: fix trivial build error in mpc5200_dma.c
2012-02-27 23:56 ` Mark Brown
@ 2012-02-28 0:43 ` Paul Gortmaker
2012-02-28 10:27 ` Mark Brown
0 siblings, 1 reply; 6+ messages in thread
From: Paul Gortmaker @ 2012-02-28 0:43 UTC (permalink / raw)
To: Mark Brown; +Cc: Timur Tabi, perex, tiwai, lrg, linux-next
On Mon, Feb 27, 2012 at 6:56 PM, Mark Brown
<broonie@opensource.wolfsonmicro.com> wrote:
> On Mon, Feb 27, 2012 at 03:56:38PM -0600, Timur Tabi wrote:
>> Mark Brown wrote:
>
>> > Please also try to use changelog headers consistent with the subsystem.
>
>> Can you explain what that means? What are "changelog headers"?
>
> The first line of the changelog which gets treated specially in various
> ways.
Automated scripts? Something else? I'd be interested to know.
I have to admit being confused by this as well. I paged through the
git whatchanged info, and guessed that I should have used a prefix
like "ASoC: mpc5200_dma" (camelcase sic) but I think that to expect
that level of awareness from general contributors is probably expecting
a bit much. I like to think I'm not totally clueless, but I would have
never thought of the above in advance...
In any case, if I have further fixups I happen across, I will try to feed
your bots the correct prefix.
Paul.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] sound: fix trivial build error in mpc5200_dma.c
2012-02-28 0:43 ` Paul Gortmaker
@ 2012-02-28 10:27 ` Mark Brown
0 siblings, 0 replies; 6+ messages in thread
From: Mark Brown @ 2012-02-28 10:27 UTC (permalink / raw)
To: Paul Gortmaker; +Cc: Timur Tabi, perex, tiwai, lrg, linux-next
[-- Attachment #1: Type: text/plain, Size: 1574 bytes --]
On Mon, Feb 27, 2012 at 07:43:20PM -0500, Paul Gortmaker wrote:
> On Mon, Feb 27, 2012 at 6:56 PM, Mark Brown
> > The first line of the changelog which gets treated specially in various
> > ways.
> Automated scripts? Something else? I'd be interested to know.
Things that use log summaries like git send-email and request-pull which
pick out the first line of the changelog and do something different with
it.
> I have to admit being confused by this as well. I paged through the
> git whatchanged info, and guessed that I should have used a prefix
> like "ASoC: mpc5200_dma" (camelcase sic) but I think that to expect
> that level of awareness from general contributors is probably expecting
> a bit much. I like to think I'm not totally clueless, but I would have
> never thought of the above in advance...
Well, most people seem to manage to get it right (I expect on the basis
that they write a log which looks like the other logs for the code). If
you're thinking far enough to put a subsystem prefix on the commit log
in the first place it seems reasonable to expect one that's in use
rather than just creating one.
> In any case, if I have further fixups I happen across, I will try to feed
> your bots the correct prefix.
It's nothing custom on my side, I only use the vanilla git porcelain
(though I do do things like grepping mailing lists visually so when
things aren't CCed properly I'm less likely to notice the mailing list
version of them). I'd expect there are people with subject line based
filters, though - patchwork might care for example.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-02-28 10:27 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-02-25 21:12 [PATCH] sound: fix trivial build error in mpc5200_dma.c Paul Gortmaker
2012-02-27 14:59 ` Mark Brown
2012-02-27 21:56 ` Timur Tabi
2012-02-27 23:56 ` Mark Brown
2012-02-28 0:43 ` Paul Gortmaker
2012-02-28 10:27 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).