From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: "usb: gadget: pch_udc: Detecting VBUS through GPIO with interrupt" breaks sparc Date: Mon, 5 Mar 2012 08:43:08 -0800 Message-ID: <20120305164308.GE2459@kroah.com> References: <4F51432C.8020204@windriver.com> <20120303104142.9615e7a2d9330a5443e0e027@canb.auug.org.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pw0-f46.google.com ([209.85.160.46]:46907 "EHLO mail-pw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757028Ab2CEQxp (ORCPT ); Mon, 5 Mar 2012 11:53:45 -0500 Received: by mail-pw0-f46.google.com with SMTP id un15so2970293pbc.19 for ; Mon, 05 Mar 2012 08:53:45 -0800 (PST) Content-Disposition: inline In-Reply-To: <20120303104142.9615e7a2d9330a5443e0e027@canb.auug.org.au> Sender: linux-next-owner@vger.kernel.org List-ID: To: Stephen Rothwell , tomoya.rohm@gmail.com Cc: Paul Gortmaker , Felipe Balbi , linux-next@vger.kernel.org On Sat, Mar 03, 2012 at 10:41:42AM +1100, Stephen Rothwell wrote: > [Just cc'ing Greg as this commit is in the usb tree] > > On Fri, 2 Mar 2012 17:01:16 -0500 Paul Gortmaker wrote: > > > > This commit: > > > > --------------- > > commit 637b78eb31e0b167ed913f1750bb645dfeda38f0 > > Author: Tomoya MORINAGA > > Date: Fri Feb 3 16:14:18 2012 +0900 > > > > usb: gadget: pch_udc: Detecting VBUS through GPIO with interrupt > > > > Problem: > > pch_udc continues operation even if VBUS becomes Low. > > pch_udc performs D+ pulling up before VBUS becomes High. > > USB device should be controlled according to VBUS state. > > > > Root cause: > > The current pch_udc is not always monitoring VBUS. > > > > Solution: > > The change of VBUS is detected using an interrupt of GPIO. > > If VBUS became Low, pch_udc handles 'disconnect'. > > After VBUS became High, a pull improves D+, and pch_udc > > handles 'connect'. > > > > [ balbi@ti.com : make it actually compile ] > > > > Signed-off-by: Tomoya MORINAGA > > Signed-off-by: Felipe Balbi > > --------------- > > > > breaks the sparc builds in next: > > > > http://kisskb.ellerman.id.au/kisskb/buildresult/5771890/ > > http://kisskb.ellerman.id.au/kisskb/buildresult/5771905/ Ick, not good. Tomoya, can you please send me a patch to fix this? Felipe is off-line for a few days and can't do this himself. greg k-h