linux-next broken by "ARM: S3C2440: move mach-s3c2440/* into mach-s3c24xx/"

linux-next broken by "ARM: S3C2440: move mach-s3c2440/* into mach-s3c24xx/"

[Paul Gortmaker]

Something bad happened in this commit (dd6f01b5cc).  It looks like
the moved file is truncated, causing this failure:

http://kisskb.ellerman.id.au/kisskb/buildresult/5818815/

I believe it came in via the fix/asoc tree.

Paul.
--

paul@yow-lpgnfs-02:~/git/linux-head$ git show `git rev-list --merges dd6f01b5cc..mar8|tail -n1`
commit 79ad0a5e9210b165c62e269eb48ade9361c630f3
Merge: 94a8d5c 539d3d8
Author: Takashi Iwai <tiwai@suse.de>
Date:   Thu Sep 24 09:16:15 2009 +0200

    Merge branch 'fix/asoc' into for-next

paul@yow-lpgnfs-02:~/git/linux-head$ 

Re: linux-next broken by "ARM: S3C2440: move mach-s3c2440/* into mach-s3c24xx/"

[Mark Brown]

On Thu, Mar 08, 2012 at 11:23:26AM -0500, Paul Gortmaker wrote:
> Something bad happened in this commit (dd6f01b5cc).  It looks like
> the moved file is truncated, causing this failure:

> http://kisskb.ellerman.id.au/kisskb/buildresult/5818815/

> I believe it came in via the fix/asoc tree.

Hrm?  What is "it" in this context, and what was your analysis here?
Nothing in the page you're linking to above suggests something audio
related...

Re: linux-next broken by "ARM: S3C2440: move mach-s3c2440/* into mach-s3c24xx/"

[Paul Gortmaker]

On 12-03-08 02:12 PM, Mark Brown wrote:
> On Thu, Mar 08, 2012 at 11:23:26AM -0500, Paul Gortmaker wrote:
>> Something bad happened in this commit (dd6f01b5cc).  It looks like
>> the moved file is truncated, causing this failure:
> 
>> http://kisskb.ellerman.id.au/kisskb/buildresult/5818815/
> 
>> I believe it came in via the fix/asoc tree.
> 
> Hrm?  What is "it" in this context, and what was your analysis here?
> Nothing in the page you're linking to above suggests something audio
> related...

The "it" was the commit in the subject, and the ID in the above text.
That was the last commit to have touched this file (via moving it).

What I took as a relation to fix/asoc was shown in the text you've
gone and deleted here in the follow up.

In any case, it does appear the file was broken before it was moved.
The offending commit is actually c1ba544f81544ed9613ad5d058968533dbcef4b2

	"ARM: S3C24XX: Fix restart on S3C2442"

It appears that a closing brace was dropped when it was integrated.

Paul.

Re: linux-next broken by "ARM: S3C2440: move mach-s3c2440/* into mach-s3c24xx/"

[Heiko Stübner]

Am Donnerstag 08 März 2012, 20:58:44 schrieb Paul Gortmaker:
> On 12-03-08 02:12 PM, Mark Brown wrote:
> > On Thu, Mar 08, 2012 at 11:23:26AM -0500, Paul Gortmaker wrote:
> >> Something bad happened in this commit (dd6f01b5cc).  It looks like
> >> the moved file is truncated, causing this failure:
> >> 
> >> http://kisskb.ellerman.id.au/kisskb/buildresult/5818815/
> >> 
> >> I believe it came in via the fix/asoc tree.
> > 
> > Hrm?  What is "it" in this context, and what was your analysis here?
> > Nothing in the page you're linking to above suggests something audio
> > related...
> 
> The "it" was the commit in the subject, and the ID in the above text.
> That was the last commit to have touched this file (via moving it).
> 
> What I took as a relation to fix/asoc was shown in the text you've
> gone and deleted here in the follow up.
> 
> In any case, it does appear the file was broken before it was moved.
> The offending commit is actually c1ba544f81544ed9613ad5d058968533dbcef4b2
> 
> 	"ARM: S3C24XX: Fix restart on S3C2442"
> 
> It appears that a closing brace was dropped when it was integrated.

kgene wrote in "[PATCH] ARM: S3C2440: Fixed build error for s3c244x":
> This happened when I applied Heiko's 'Fix restart on S3C2442'.
> It was my fault :( and this should be sent before release v3.3.

and was applied by Olof today.


Heiko

Re: linux-next broken by "ARM: S3C2440: move mach-s3c2440/* into mach-s3c24xx/"

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 854 bytes --]

On Thu, Mar 08, 2012 at 02:58:44PM -0500, Paul Gortmaker wrote:

> The "it" was the commit in the subject, and the ID in the above text.
> That was the last commit to have touched this file (via moving it).

> What I took as a relation to fix/asoc was shown in the text you've
> gone and deleted here in the follow up.

You'd written some text but the text wasn't teribly clear - nothing
about the code looks at all audio bug fix related.  Are you sure the
error wasn't just in Linus' tree?

> In any case, it does appear the file was broken before it was moved.
> The offending commit is actually c1ba544f81544ed9613ad5d058968533dbcef4b2

> 	"ARM: S3C24XX: Fix restart on S3C2442"

> It appears that a closing brace was dropped when it was integrated.

Right, and that commit doesn't appear to be in the ASoC bugfix branch
which is why I was mystified.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]