From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: linux-next@vger.kernel.org
Subject: Re: fix for "error: implicit declaration of function 'devres_alloc'" in Mar9 tree
Date: Sun, 11 Mar 2012 12:48:47 +0000 [thread overview]
Message-ID: <20120311124846.GA6081@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <4F5A1DBC.3090701@windriver.com>
[-- Attachment #1: Type: text/plain, Size: 1095 bytes --]
On Fri, Mar 09, 2012 at 10:11:56AM -0500, Paul Gortmaker wrote:
> drivers/base/regmap/regmap.c:421: error: implicit declaration of function 'dev_err'
> make[4]: *** [drivers/base/regmap/regmap.o] Error 1
> This is caused by commit 19694b5ea1d3 which just appeared in today's next
> tree exposing another implicit device.h user. Just a quick note that I'll
> take care of it by adding regmap.c to the below commit.
No, it's not caused by that - in the subsystem tree there's an explicit
inclusion of linux/device.h in the public header which is what is being
relied on here. You've gone and deleted that inclusion without CCing
the patch to the subsystem and now you're sending a fix again without a
CC to either me or the relevant list, and without even a mention in the
subject line.
In order to avoid bisection breakage I've applied one of the several
fixes for this that were sent to me today, please drop your change.
This stuff would go a lot more smoothly if you were to at least let
people know when you make changes, especially when issues introduced by
your changes get noticed.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-03-11 12:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-09 15:11 fix for "error: implicit declaration of function 'devres_alloc'" in Mar9 tree Paul Gortmaker
2012-03-11 12:48 ` Mark Brown [this message]
2012-03-11 16:09 ` Paul Gortmaker
2012-03-11 19:32 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120311124846.GA6081@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=linux-next@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).