From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: linux-next: build failure after merge of the scsi tree Date: Mon, 26 Mar 2012 07:07:21 -0700 Message-ID: <20120326140721.GA19827@kroah.com> References: <20120326121719.dc4c2b1faca5cf12c8d76d93@canb.auug.org.au> <1332748641.2836.8.camel@dabdike> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pb0-f46.google.com ([209.85.160.46]:34503 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757330Ab2CZOHZ (ORCPT ); Mon, 26 Mar 2012 10:07:25 -0400 Received: by pbcun15 with SMTP id un15so6032930pbc.19 for ; Mon, 26 Mar 2012 07:07:25 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1332748641.2836.8.camel@dabdike> Sender: linux-next-owner@vger.kernel.org List-ID: To: James Bottomley Cc: Stephen Rothwell , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Alexey Dobriyan On Mon, Mar 26, 2012 at 08:57:21AM +0100, James Bottomley wrote: > On Mon, 2012-03-26 at 12:17 +1100, Stephen Rothwell wrote: > > Hi James, > > > > After merging the scsi tree, today's linux-next build (x86_64 allmodconfig) > > failed like this: > > > > drivers/staging/keucr/scsiglue.c:349:2: error: unknown field 'proc_info' specified in initializer > > drivers/staging/rts_pstor/rtsx.c:258:2: error: unknown field 'proc_info' specified in initializer > > drivers/staging/rts5139/rts51x_scsi.c:2190:2: error: unknown field 'proc_info' specified in initializer > > > > Caused by commit 104c4fe25dc9 ("[SCSI] remove scsi_host_template::proc_info"). > > > > Since this is a staging driver, I applied these following patches: > > Yes, that looks about right, thanks. We haven't seen anything about > these drivers on the SCSI list, so I've no idea where they are in > development. Why is new patches going into your tree right now, during the 3.4 merge window? API changes should have happened weeks ago, to let others fix up things like this. As for the "where they are in development", they vary, but, a simple grep should have shown you that these in-kernel drivers should also be fixed up, or at the least, give me the heads up to let me do it for you. Care to send me the patch that causes this problem so I can create a fix for this? thanks, greg k-h