Re: linux-next: "amba: Remove AMBA level regulator support" commit.

Shawn Guo
2012-04-13T02:01:54Z

On 13 April 2012 09:22, Paul Gortmaker <paul.gortmaker@windriver.com> wrote:
> Hi Mark,
>
> The commit in linux-next:
>
> -----------------
> commit b2bc9e0ee349db84035d8141e85babc7986594d7
> Author: Mark Brown <broonie@sirena.org.uk>
> Date:   Mon Apr 2 12:30:35 2012 +0100
>
>    ARM: 7366/1: amba: Remove AMBA level regulator support
> -----------------
>
> is pointed at by git bisect for the u8500_defconfig build failure:
>
> drivers/dma/ste_dma40.c:2708:3: error: implicit declaration of function
> 'regulator_disable' [-Werror=implicit-function-declaration]
> drivers/dma/ste_dma40.c:2747:3: error: implicit declaration of function
> 'regulator_enable' [-Werror=implicit-function-declaration]
> drivers/dma/ste_dma40.c:3260:3: error: implicit declaration of function
> 'regulator_get' [-Werror=implicit-function-declaration]
> drivers/dma/ste_dma40.c:3271:4: error: implicit declaration of function
> 'regulator_put' [-Werror=implicit-function-declaration]
>
That's because Mark's patch removes "#include
<linux/regulator/consumer.h>" included indirectly by
drivers/dma/ste_dma40.c from linux/amba/bus.h. The ste_dma40.c should
really directly includes consumer.h.

Regards,
Shawn