From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Anton Vorontsov <avorontsov@ru.mvista.com>,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: linux-next: build failure after merge of the final tree (battery tree related)
Date: Mon, 7 May 2012 11:26:37 +0300 [thread overview]
Message-ID: <20120507082637.GH31494@intel.com> (raw)
In-Reply-To: <20120507171458.5ce17d20c40856e9440b3e5f@canb.auug.org.au>
On Mon, May 07, 2012 at 05:14:58PM +1000, Stephen Rothwell wrote:
>
> After merging the final tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
>
> drivers/power/smb347-charger.c: In function 'smb347_probe':
> drivers/power/smb347-charger.c:1039:2: error: implicit declaration of function 'IS_ERR' [-Werror=implicit-function-declaration]
> drivers/power/smb347-charger.c:1040:3: error: implicit declaration of function 'PTR_ERR' [-Werror=implicit-function-declaration]
>
> Caused by commit 34298d40e585 ("smb347-charger: Convert to regmap API").
I'm unable to reproduce this on x86 build. I guess <linux/err.h> gets
included implicitly there.
Patch below should fix this. Anton, care to pick this one as well (or fold
it into the 34298d40e585 ("smb347-charger: Convert to regmap API") commit)?
From: Mika Westerberg <mika.westerberg@linux.intel.com>
Subject: [PATCH] smb347-charger: include missing <linux/err.h>
Without the include we get build errors like:
drivers/power/smb347-charger.c: In function 'smb347_probe':
drivers/power/smb347-charger.c:1039:2: error: implicit declaration of function 'IS_ERR' [-Werror=implicit-function-declaration]
drivers/power/smb347-charger.c:1040:3: error: implicit declaration of function 'PTR_ERR' [-Werror=implicit-function-declaration]
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
---
drivers/power/smb347-charger.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/power/smb347-charger.c b/drivers/power/smb347-charger.c
index 09d19d2..f8eedd8 100644
--- a/drivers/power/smb347-charger.c
+++ b/drivers/power/smb347-charger.c
@@ -11,6 +11,7 @@
* published by the Free Software Foundation.
*/
+#include <linux/err.h>
#include <linux/gpio.h>
#include <linux/kernel.h>
#include <linux/module.h>
--
1.7.9.1
next prev parent reply other threads:[~2012-05-07 8:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-07 7:14 linux-next: build failure after merge of the final tree (battery tree related) Stephen Rothwell
2012-05-07 8:26 ` Mika Westerberg [this message]
2012-05-16 6:12 ` Stephen Rothwell
2012-05-19 0:16 ` Anton Vorontsov
-- strict thread matches above, loose matches on Subject: below --
2011-04-21 22:05 Stephen Rothwell
2011-04-21 23:27 ` Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120507082637.GH31494@intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=avorontsov@ru.mvista.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).