From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [patch -linus] regmap: REMAP_IRQ should select IRQ_DOMAIN itself Date: Thu, 24 May 2012 02:19:51 +0100 Message-ID: <20120524011950.GD5361@opensource.wolfsonmicro.com> References: <20120522183037.75ec03c9d8881ec188e7f787@canb.auug.org.au> <4FBBAF1B.1070702@xenotime.net> <20120523093208.GB4085@opensource.wolfsonmicro.com> <20120523173342.GB4064@opensource.wolfsonmicro.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="5p8PegU4iirBW1oA" Return-path: Received: from opensource.wolfsonmicro.com ([80.75.67.52]:40143 "EHLO opensource.wolfsonmicro.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752774Ab2EXBT4 (ORCPT ); Wed, 23 May 2012 21:19:56 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-next-owner@vger.kernel.org List-ID: To: David Rientjes Cc: Linus Torvalds , Randy Dunlap , Stephen Rothwell , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org --5p8PegU4iirBW1oA Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, May 23, 2012 at 05:36:38PM -0700, David Rientjes wrote: > What's fragile is going around and adding "select IRQ_DOMAIN" to=20 > everything that does "select REGMAP_IRQ". So I removed that and just mad= e=20 > IRQ_DOMAIN select REGMAP_IRQ itself. It's a different kind of fragility, things break immediately when you add something new which is reasonably obvous as opposed to happening at some other time due to a tooling issue and what I'm concerned about avoiding. In any case... > So can this be merged or what's the issue? =2E..Linus already merged my alternative patch which does this with a select..if which never seems to have these issues. Your patch *should* work but due to past issues and the fact that I can understand why they might occur (the semantic of select is "just enable this" which doesn't pay too much attention to the target) I'd rather go with this different approach. --5p8PegU4iirBW1oA Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iQIcBAEBAgAGBQJPvYyuAAoJEBus8iNuMP3d5ssP/0pzUPPKUV7GJ1S37Z2hE3r/ OK8Wq9HHNZEh1BM4OsSZTYnEWKbhM+Be2a4pjVFGk8BuhLymjJ8Ltf0yQfoRr48U Vlwdge9OpMcG5xi3bvnx/fbBbDHvuJuiRO+vKiYQIMIdO2tfKdRv/9mZ4+RdodU9 nPMMl1XHKiY6POLmGU/G/F38SfOEcWfzcteaUvJEknig9xxxhHKTtsGTIItSsiaR 5XHsMOI7PFahmuB+M2ujiAeaW83ThsMlbw+ho1nbxw2GgHmKNaHfS25EXzF2c0mB wV43e3eP/+f7vNgCeDRoRu7kJHtB+++EkhfTWmOirydrX9P/B3FpJJVZ3/yFJWbo bJ4Fqn14fDbKBnt2I6nUXqJP0Pak5cXjclRvFuYK4j+1RyPNYjUmz1TbsyoEUpzh sjULD3ZUmkFRwtuAHjLKsVCBe25/kCZVMH8gU0FIEs3DPAYk4X9+jZJFQC701klx kkexJY8zfd72qcwTCfKA9OZ/53QKOal8MM14lWpj7AtX5pgUEe+MIFtXMGs1EqTN gepkGKjBbFSLSuLPBBjgHWlD7AQ987kDOEE7r8pAbYDlhqRcgL84c5WJu+CVg1+M rRcTHvRLpWaGayk6taM8Ne5yaKqTeEePoOXPrVhBv9WYI4k09MzMUuwd6DrECFYU pilqhHCdkXFChxoUeMzn =GrZZ -----END PGP SIGNATURE----- --5p8PegU4iirBW1oA--