linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Fengguang Wu <fengguang.wu@intel.com>
To: viresh kumar <viresh.linux@gmail.com>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>,
	Russell King <linux@arm.linux.org.uk>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Viresh Kumar <viresh.kumar@st.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-next@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	spear-devel <spear-devel@list.st.com>
Subject: Re: "clk: add non CONFIG_HAVE_CLK routines" commit
Date: Tue, 12 Jun 2012 19:09:29 +0800	[thread overview]
Message-ID: <20120612110929.GA16511@localhost> (raw)
In-Reply-To: <CAOh2x=mFOPKbzuY__k0RVpFHTdPfa-iN1e3Lpa3iWt9iP6FzFw@mail.gmail.com>

> Following are present in mach-netx/fb.c:
[snip]
> struct clk *clk_get(struct device *dev, const char *id)
> {
> 	return dev && strcmp(dev_name(dev), "fb") == 0 ? NULL : ERR_PTR(-ENOENT);
> }
> 
> I can remove first four without any issues, but just can't remove the last one.
> The dummy clk_get() always returns NULL, whereas this one returns NULL only for
> fb device.
> 
> How should I fix this?

Another thing I'm not sure is that the typical clk_get() callers only
tests IS_ERR() on the returned value. As a clk newbie, I don't know
whether there will be lots of clk users seeing this (new) NULL value
on !CONFIG_HAVE_CLK and whether the current behavior is correct..

Thanks,
Fengguang

  reply	other threads:[~2012-06-12 11:09 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-22 23:46 "clk: add non CONFIG_HAVE_CLK routines" commit Paul Gortmaker
2012-05-25  9:37 ` [linux-next] " viresh kumar
2012-06-12 10:57 ` viresh kumar
2012-06-12 11:09   ` Fengguang Wu [this message]
2012-06-12 11:13     ` viresh kumar
2012-06-12 14:08   ` Russell King - ARM Linux
2012-06-12 14:21     ` [linux-next] " viresh kumar
2012-06-13 22:10   ` Sascha Hauer
2012-06-14 10:04     ` Russell King - ARM Linux
2012-06-14 10:18       ` Sascha Hauer
2012-06-14 10:21         ` viresh kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120612110929.GA16511@localhost \
    --to=fengguang.wu@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-next@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=paul.gortmaker@windriver.com \
    --cc=s.hauer@pengutronix.de \
    --cc=spear-devel@list.st.com \
    --cc=viresh.kumar@st.com \
    --cc=viresh.linux@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).