From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: viresh kumar <viresh.linux@gmail.com>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Viresh Kumar <viresh.kumar@st.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-next@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
fengguang.wu@intel.com, spear-devel <spear-devel@list.st.com>
Subject: Re: "clk: add non CONFIG_HAVE_CLK routines" commit
Date: Tue, 12 Jun 2012 15:08:01 +0100 [thread overview]
Message-ID: <20120612140801.GA7918@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <CAOh2x=mFOPKbzuY__k0RVpFHTdPfa-iN1e3Lpa3iWt9iP6FzFw@mail.gmail.com>
On Tue, Jun 12, 2012 at 11:57:07AM +0100, viresh kumar wrote:
> struct clk *clk_get(struct device *dev, const char *id)
> {
> return dev && strcmp(dev_name(dev), "fb") == 0 ? NULL : ERR_PTR(-ENOENT);
> }
>
> I can remove first four without any issues, but just can't remove the
> last one. The dummy clk_get() always returns NULL, whereas this one
> returns NULL only for fb device.
This isn't a totally dummy clk implementation. What it's doing is returning
a dummy clock for the framebuffer, and explicitly failing everything else
(because we have no need to support any other clocks.)
If we want to use the dummy clk stuff in its entirety, and just return the
dummy clock for all clk_get()s on this platform, then there isn't a problem.
If we want to keep this behaviour, we need to use clkdev with the dummy
clk implementation.
next prev parent reply other threads:[~2012-06-12 14:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-22 23:46 "clk: add non CONFIG_HAVE_CLK routines" commit Paul Gortmaker
2012-05-25 9:37 ` [linux-next] " viresh kumar
2012-06-12 10:57 ` viresh kumar
2012-06-12 11:09 ` Fengguang Wu
2012-06-12 11:13 ` viresh kumar
2012-06-12 14:08 ` Russell King - ARM Linux [this message]
2012-06-12 14:21 ` [linux-next] " viresh kumar
2012-06-13 22:10 ` Sascha Hauer
2012-06-14 10:04 ` Russell King - ARM Linux
2012-06-14 10:18 ` Sascha Hauer
2012-06-14 10:21 ` viresh kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120612140801.GA7918@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=fengguang.wu@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-next@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=s.hauer@pengutronix.de \
--cc=spear-devel@list.st.com \
--cc=viresh.kumar@st.com \
--cc=viresh.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).