From mboxrd@z Thu Jan  1 00:00:00 1970
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: linux-next: Tree for Jun 18 (kmsg problems)
Date: Mon, 18 Jun 2012 15:35:14 -0700
Message-ID: <20120618223514.GA28749@kroah.com>
References: <20120618165336.48345227c6b64c314326ae57@canb.auug.org.au>
 <4FDF61A7.3050601@xenotime.net>
 <20120619080109.b28055c1b32fb81027a9562b@canb.auug.org.au>
 <20120618221535.GA13037@kroah.com>
 <CAPXgP10sBkwLnhDmu6UG9yVaiXG+8UYGkBEOVzUp3H+468J03w@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: QUOTED-PRINTABLE
Return-path: <linux-next-owner@vger.kernel.org>
Received: from mail-pb0-f46.google.com ([209.85.160.46]:53987 "EHLO
	mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752848Ab2FRWfT (ORCPT
	<rfc822;linux-next@vger.kernel.org>); Mon, 18 Jun 2012 18:35:19 -0400
Received: by pbbrp8 with SMTP id rp8so8800332pbb.19
        for <linux-next@vger.kernel.org>; Mon, 18 Jun 2012 15:35:18 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <CAPXgP10sBkwLnhDmu6UG9yVaiXG+8UYGkBEOVzUp3H+468J03w@mail.gmail.com>
Sender: linux-next-owner@vger.kernel.org
List-ID: <linux-next.vger.kernel.org>
To: Kay Sievers <kay@vrfy.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>, Randy Dunlap <rdunlap@xenotime.net>, linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>

On Tue, Jun 19, 2012 at 12:17:01AM +0200, Kay Sievers wrote:
> On Tue, Jun 19, 2012 at 12:15 AM, Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> > On Tue, Jun 19, 2012 at 08:01:09AM +1000, Stephen Rothwell wrote:
> >> [Adding Greg and Kay]
> >>
> >> On Mon, 18 Jun 2012 10:13:11 -0700 Randy Dunlap <rdunlap@xenotime.=
net> wrote:
> >> >
> >> > on x86_64:
> >> >
> >> > arch/x86/kernel/reboot.o: In function `kmsg_dump_get_line':
> >> > reboot.c:(.text+0xf0): multiple definition of `kmsg_dump_get_lin=
e'
> >> > arch/x86/kernel/setup.o:setup.c:(.text+0x0): first defined here
> >> > arch/x86/kernel/reboot.o: In function `kmsg_dump_get_buffer':
> >> > reboot.c:(.text+0x100): multiple definition of `kmsg_dump_get_bu=
ffer'
> >> > arch/x86/kernel/setup.o:setup.c:(.text+0x10): first defined here
> >> > arch/x86/kernel/reboot.o: In function `kmsg_dump_rewind':
> >> > reboot.c:(.text+0x110): multiple definition of `kmsg_dump_rewind=
'
> >> > arch/x86/kernel/setup.o:setup.c:(.text+0x20): first defined here
> >>
> >> Caused by commit e2ae715d66bf ("kmsg - kmsg_dump() use iterator to
> >> receive log buffer content") from the driver-core.current tree.
> >
> > I'm building my tree right now, and I can't seem to hit this.
> >
> >> This was reported a few days ago. =A0Why is it not fixed yet?
> >
> > It was reported Friday evening, on a holiday weekend for some of us=
, we
> > are trying the best we can :)
> >
> >> Especially since it is in a branch that is supposedly "bug fixes"?
> >
> > It fixes up a reported problem, and we had 3 people test it and sai=
d it
> > resolved the issue for them, no build problems reported.
> >
> > Randy, can I get a copy of your .config that duplicates this?
>=20
> I looked at it, and did not see it, I was blind.
>=20
> We just miss the "static inline" in include/linux/kmsg_dump.h. :)

Ah, care to send a patch?