linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paul Mundt <lethal@linux-sh.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Andi Kleen <andi@firstfloor.org>,
	linux-kernel@vger.kernel.org,
	Linux-Next <linux-next@vger.kernel.org>,
	Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH] Makefile: fix up CROSS_COMPILE and READABLE_ASM interaction.
Date: Tue, 19 Jun 2012 21:13:38 +0900	[thread overview]
Message-ID: <20120619121337.GA5623@linux-sh.org> (raw)
In-Reply-To: <CAMuHMdU5juQMyzoTV62-hwzKW980fkQNDBKGP8i5WfDcsf95jQ@mail.gmail.com>

On Tue, Jun 19, 2012 at 11:17:59AM +0200, Geert Uytterhoeven wrote:
> On Mon, Jun 18, 2012 at 6:55 AM, Paul Mundt <lethal@linux-sh.org> wrote:
> > (Apologies for the re-send, forgot to Cc linux-kernel)
> >
> > When the READABLE_ASM cc-option tests were added they were done so prior
> > to the arch Makefile include, resulting in cc-option being run on the
> > host cc instead of the factoring in the cross prefix set up by the
> > architecture.
> >
> > This bumps the include back up so that cc-option actually runs on the
> > compiler that we're building with.
> 
> I find it a real pity these reported, hard to investigate, and fixed
> build issues keep
> flowing into mainline, without the corresponding fix...
> 
> https://lkml.org/lkml/2012/5/12/36
> 
Agreed. These one-off things are always a nuisance, and often fall
through the cracks. I've yet to find a good solution for them, although
having them rolled in to -next helps.

In this case I got bit by -fno-partial-inlining instead, and since you
didn't have READABLE_ASM in the subject I missed your patch entirely. In
retrospect I should have searched for cc-option. At least we've now both
scratched our heads and come up with an identical fix independently,
which counts a lot more than a Tested-by ;-)

      reply	other threads:[~2012-06-19 12:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20120618045500.GC19803@linux-sh.org>
2012-06-19  9:17 ` [PATCH] Makefile: fix up CROSS_COMPILE and READABLE_ASM interaction Geert Uytterhoeven
2012-06-19 12:13   ` Paul Mundt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120619121337.GA5623@linux-sh.org \
    --to=lethal@linux-sh.org \
    --cc=andi@firstfloor.org \
    --cc=geert@linux-m68k.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).