From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sam Ravnborg Subject: Re: [PATCH] mod/file2alias: make modalias generation safe for cross compiling Date: Tue, 26 Jun 2012 07:00:49 +0200 Message-ID: <20120626050049.GA24503@merkur.ravnborg.org> References: <20120615201021.GB14544@kroah.com> <20120615231220.GC8205@kroah.com> <87lijns84s.fsf@nemi.mork.no> <87fw9urqau.fsf@nemi.mork.no> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-m68k-owner@vger.kernel.org To: Andreas Schwab Cc: =?iso-8859-1?Q?Bj=F8rn?= Mork , Greg Kroah-Hartman , Geert Uytterhoeven , USB list , linux-kernel@vger.kernel.org, Linux-Next , linux-kbuild , Linux/m68k List-Id: linux-next.vger.kernel.org Hi Andreas. On Mon, Jun 25, 2012 at 02:22:34PM +0200, Andreas Schwab wrote: > Use the target compiler to compute the offsets of the fields of the > device_id structures, so that it won't be broken by different alignments > between the host and target ABIs. Looks good. > diff --git a/scripts/Makefile.modpost b/scripts/Makefile.modpost > index 08dce14..ff22206 100644 > --- a/scripts/Makefile.modpost > +++ b/scripts/Makefile.modpost > @@ -80,8 +80,7 @@ modpost = scripts/mod/modpost \ > $(if $(KBUILD_EXTRA_SYMBOLS), $(patsubst %, -e %,$(KBUILD_EXTRA_SYMBOLS))) \ > $(if $(KBUILD_EXTMOD),-o $(modulesymfile)) \ > $(if $(CONFIG_DEBUG_SECTION_MISMATCH),,-S) \ > - $(if $(KBUILD_EXTMOD)$(KBUILD_MODPOST_WARN),-w) \ > - $(if $(cross_build),-c) > + $(if $(KBUILD_EXTMOD)$(KBUILD_MODPOST_WARN),-w) With this change we can kill cross_build, and thus we can drop KBUILD_BUILDHOST too (from top-level Makefile). Sam