From: Andrew Morton <akpm@linux-foundation.org>
To: Randy Dunlap <rdunlap@xenotime.net>
Cc: linux-kernel@vger.kernel.org,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-next@vger.kernel.org, Mike Lockwood <lockwood@android.com>,
Andrzej Pietrasiewicz <andrzej.p@samsung.com>
Subject: Re: mmotm 2012-07-10-16-59 uploaded (staging/ccg)
Date: Wed, 11 Jul 2012 15:16:44 -0700 [thread overview]
Message-ID: <20120711151644.23016bd8.akpm@linux-foundation.org> (raw)
In-Reply-To: <4FFDF7BC.6050602@xenotime.net>
On Wed, 11 Jul 2012 15:01:32 -0700
Randy Dunlap <rdunlap@xenotime.net> wrote:
> In file included from drivers/staging/ccg/ccg.c:59:0:
> drivers/staging/ccg/../../usb/gadget/f_fs.c:41:0: warning: "pr_vdebug" redefined
> drivers/staging/ccg/../../usb/gadget/u_serial.c:138:0: note: this is the location of the previous definition
<looks at drivers/staging/ccg/ccg.c>
: /*
: * Kbuild is not very cooperative with respect to linking separately
: * compiled library objects into one module. So for now we won't use
: * separate compilation ... ensuring init/exit sections work to shrink
: * the runtime footprint, and giving us at least some parts of what
: * a "gcc --combine ... part1.c part2.c part3.c ... " build would.
: */
: #include "../../usb/gadget/usbstring.c"
: #include "../../usb/gadget/config.c"
: #include "../../usb/gadget/epautoconf.c"
: #include "../../usb/gadget/composite.c"
:
: #include "../../usb/gadget/f_mass_storage.c"
: #include "../../usb/gadget/u_serial.c"
: #include "../../usb/gadget/f_acm.c"
: #define USB_ETH_RNDIS y
: #include "../../usb/gadget/f_rndis.c"
: #include "../../usb/gadget/rndis.c"
: #include "../../usb/gadget/u_ether.c"
: #include "../../usb/gadget/f_fs.c"
What nonsense is this?
Who wrote that rotten comment? What does "not very cooperative" mean?
This alleged lack of cooperation is the central issue, but you couldn't
be bothered actually describing it? How the heck is anyone else to
understand the problem and suggest fixes? argh.
It talks about library objects. Really? Is there a .a file
involved here, or is that just a thinko? If there is indeed a .a file
then I'm not surprised there are problems: don't do that. If instead
we're just talking about a bunch of .o files then I'm rather curious to
know what "not very cooperative" means.
next prev parent reply other threads:[~2012-07-11 22:16 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-11 0:01 mmotm 2012-07-10-16-59 uploaded akpm
2012-07-11 6:38 ` Artem Bityutskiy
2012-07-11 7:44 ` Andrew Morton
2012-07-11 7:53 ` Artem Bityutskiy
2012-07-11 7:59 ` Andrew Morton
2012-07-11 8:08 ` Artem Bityutskiy
2012-07-11 8:15 ` Andrew Morton
2012-07-11 9:09 ` Johannes Weiner
2012-07-11 9:09 ` Johannes Weiner
2012-07-11 9:09 ` Johannes Weiner
2012-07-11 10:34 ` Michal Hocko
2012-07-11 22:01 ` mmotm 2012-07-10-16-59 uploaded (staging/ccg) Randy Dunlap
2012-07-11 22:16 ` Andrew Morton [this message]
2012-07-11 23:38 ` Nicholas A. Bellinger
2012-07-11 23:57 ` Andrew Morton
2012-07-12 9:00 ` Andrzej Pietrasiewicz
2012-07-12 14:46 ` Randy Dunlap
2012-07-12 15:23 ` 'Greg Kroah-Hartman'
2012-07-13 11:42 ` mmotm 2012-07-10-16-59 uploaded S, Venkatraman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120711151644.23016bd8.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=andrzej.p@samsung.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=lockwood@android.com \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).