linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
To: Randy Dunlap <rdunlap@xenotime.net>, Felipe Balbi <balbi@ti.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
	linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
	USB list <linux-usb@vger.kernel.org>
Subject: [PATCH] usb/gadget: let file storage gadget select libcomposite
Date: Wed, 24 Oct 2012 16:44:35 +0200	[thread overview]
Message-ID: <20121024144435.GF4368@breakpoint.cc> (raw)
In-Reply-To: <50809624.30601@xenotime.net>

From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Date: Wed, 24 Oct 2012 16:40:10 +0200

found by randconfig, Randy Dunlap and Stephen Rothwell:

|drivers/built-in.o: In function `fsg_setup':
|file_storage.c:(.text+0x24db7c): undefined reference to `usb_gadget_config_buf'
|file_storage.c:(.text+0x24db98): undefined reference to `usb_gadget_get_string'
|drivers/built-in.o: In function `fsg_bind':
|file_storage.c:(.init.text+0xee42): undefined reference to `usb_ep_autoconfig_reset'
|file_storage.c:(.init.text+0xee51): undefined reference to `usb_ep_autoconfig'
|file_storage.c:(.init.text+0xee73): undefined reference to `usb_ep_autoconfig'
|file_storage.c:(.init.text+0xee9e): undefined reference to `usb_ep_autoconfig'

Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---
for v3.7 please.

 drivers/usb/gadget/Kconfig |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig
index bbcec83..66bc3ab 100644
--- a/drivers/usb/gadget/Kconfig
+++ b/drivers/usb/gadget/Kconfig
@@ -737,6 +737,7 @@ config USB_FUNCTIONFS_GENERIC
 
 config USB_FILE_STORAGE
 	tristate "File-backed Storage Gadget (DEPRECATED)"
+	select USB_LIBCOMPOSITE
 	depends on BLOCK
 	help
 	  The File-backed Storage Gadget acts as a USB Mass Storage
-- 
1.7.10.4

  reply	other threads:[~2012-10-24 14:44 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-18  3:46 linux-next: Tree for Oct 18 Stephen Rothwell
2012-10-18 23:50 ` linux-next: Tree for Oct 18 (drm/i915) Randy Dunlap
2012-10-18 23:52 ` linux-next: Tree for Oct 18 (usb/gadget) Randy Dunlap
2012-10-24 14:44   ` Sebastian Andrzej Siewior [this message]
2012-10-24 17:30     ` [PATCH] usb/gadget: let file storage gadget select libcomposite Michal Nazarewicz
2012-10-24 17:45       ` Sebastian Andrzej Siewior
2012-10-24 18:47         ` Michal Nazarewicz
2012-10-31 12:37           ` Felipe Balbi
     [not found]             ` <20121031123749.GE10998-S8G//mZuvNWo5Im9Ml3/Zg@public.gmane.org>
2012-10-31 12:55               ` Michal Nazarewicz
     [not found]                 ` <xa1tfw4ug5so.fsf-deATy8a+UHjQT0dZR+AlfA@public.gmane.org>
2012-10-31 12:54                   ` Felipe Balbi
2012-10-31 15:07                 ` Alan Stern
2012-10-31 15:07                   ` Felipe Balbi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121024144435.GF4368@breakpoint.cc \
    --to=sebastian@breakpoint.cc \
    --cc=balbi@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=rdunlap@xenotime.net \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).