* [PATCH] hid-picolcd_cir: fix compilation
@ 2012-10-31 8:22 David Härdeman
2012-10-31 13:51 ` Jiri Kosina
0 siblings, 1 reply; 2+ messages in thread
From: David Härdeman @ 2012-10-31 8:22 UTC (permalink / raw)
To: mchehab; +Cc: sfr, bonbons, linux-next, linux-kernel, jkosina
Commit c003ab1bedf0 ("[media] rc-core: add separate defines for
protocol bitmaps and numbers") overlooked hid-picolcd.
This patch (against git.linuxtv.org/media_tree.git, branch
staging/for_v3.8) fixes the compilation breakage.
Signed-off-by: David Härdeman <david@hardeman.nu>
---
drivers/hid/hid-picolcd_cir.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hid/hid-picolcd_cir.c b/drivers/hid/hid-picolcd_cir.c
index 13ca919..a79e95b 100644
--- a/drivers/hid/hid-picolcd_cir.c
+++ b/drivers/hid/hid-picolcd_cir.c
@@ -116,7 +116,7 @@ int picolcd_init_cir(struct picolcd_data *data, struct hid_report *report)
rdev->priv = data;
rdev->driver_type = RC_DRIVER_IR_RAW;
- rdev->allowed_protos = RC_TYPE_ALL;
+ rdev->allowed_protos = RC_BIT_ALL;
rdev->open = picolcd_cir_open;
rdev->close = picolcd_cir_close;
rdev->input_name = data->hdev->name;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] hid-picolcd_cir: fix compilation
2012-10-31 8:22 [PATCH] hid-picolcd_cir: fix compilation David Härdeman
@ 2012-10-31 13:51 ` Jiri Kosina
0 siblings, 0 replies; 2+ messages in thread
From: Jiri Kosina @ 2012-10-31 13:51 UTC (permalink / raw)
To: David Härdeman; +Cc: mchehab, sfr, bonbons, linux-next, linux-kernel
On Wed, 31 Oct 2012, David Härdeman wrote:
> Commit c003ab1bedf0 ("[media] rc-core: add separate defines for
> protocol bitmaps and numbers") overlooked hid-picolcd.
>
> This patch (against git.linuxtv.org/media_tree.git, branch
> staging/for_v3.8) fixes the compilation breakage.
>
> Signed-off-by: David Härdeman <david@hardeman.nu>
> ---
> drivers/hid/hid-picolcd_cir.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hid/hid-picolcd_cir.c b/drivers/hid/hid-picolcd_cir.c
> index 13ca919..a79e95b 100644
> --- a/drivers/hid/hid-picolcd_cir.c
> +++ b/drivers/hid/hid-picolcd_cir.c
> @@ -116,7 +116,7 @@ int picolcd_init_cir(struct picolcd_data *data, struct hid_report *report)
>
> rdev->priv = data;
> rdev->driver_type = RC_DRIVER_IR_RAW;
> - rdev->allowed_protos = RC_TYPE_ALL;
> + rdev->allowed_protos = RC_BIT_ALL;
> rdev->open = picolcd_cir_open;
> rdev->close = picolcd_cir_close;
> rdev->input_name = data->hdev->name;
This has been reported by Stephen a few days ago already ... Mauro, any
plans to have that fixed up in media tree please?
Thanks,
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-10-31 13:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-31 8:22 [PATCH] hid-picolcd_cir: fix compilation David Härdeman
2012-10-31 13:51 ` Jiri Kosina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox