From mboxrd@z Thu Jan 1 00:00:00 1970 From: Samuel Ortiz Subject: Re: [PATCH -next] mfd: fix stmpe.c build when OF is not enabled Date: Mon, 26 Nov 2012 22:07:23 +0100 Message-ID: <20121126210723.GX12685@sortiz-mobl> References: <20121112164431.8bcfe78d2a2ec73271733db4@canb.auug.org.au> <50A12FF1.4000800@infradead.org> <50B3C13D.1050704@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <50B3C13D.1050704@infradead.org> Sender: linux-kernel-owner@vger.kernel.org To: Randy Dunlap Cc: Linus Walleij , Rabin Vincent , Stephen Rothwell , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-next.vger.kernel.org Hi Randy, On Mon, Nov 26, 2012 at 11:21:33AM -0800, Randy Dunlap wrote: > On 11/13/2012 05:35 AM, Linus Walleij wrote: > > > On Mon, Nov 12, 2012 at 6:20 PM, Randy Dunlap wrote: > > > >> From: Randy Dunlap > >> > >> Fix build errors when CONFIG_OF is not enabled by including > >> (needs to be added in any case). > >> An alternative fix could be to make the driver depend on OF. > >> > >> drivers/mfd/stmpe.c:1025:2: error: implicit declaration of function 'of_property_read_u32' > >> drivers/mfd/stmpe.c:1030:2: error: implicit declaration of function 'for_each_child_of_node' > >> drivers/mfd/stmpe.c:1030:36: error: expected ';' before '{' token > >> > >> Signed-off-by: Randy Dunlap > >> Cc: Rabin Vincent > >> Cc: Samuel Ortiz > > > > Acked-by: Linus Walleij > > > > > ping? > > This patch is still needed in linux-next. Applied and pushed, thanks a lot. Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/