From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stanislaw Gruszka Subject: Re: linux-next: build failure after merge of the modules tree Date: Wed, 28 Nov 2012 12:02:00 +0100 Message-ID: <20121128110145.GA3701@redhat.com> References: <20121126151046.1b5b09762b8361b1f202c6e2@canb.auug.org.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mx1.redhat.com ([209.132.183.28]:40832 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753591Ab2K1LCT (ORCPT ); Wed, 28 Nov 2012 06:02:19 -0500 Content-Disposition: inline In-Reply-To: <20121126151046.1b5b09762b8361b1f202c6e2@canb.auug.org.au> Sender: linux-next-owner@vger.kernel.org List-ID: To: Stephen Rothwell Cc: Rusty Russell , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Johannes Berg , Wey-Yi Guy , "John W. Linville" On Mon, Nov 26, 2012 at 03:10:46PM +1100, Stephen Rothwell wrote: > After merging the modules tree, today's linux-next build (x86_64 > allmodconfig) failed like this: > > drivers/net/wireless/iwlwifi/iwl-drv.c:1196:1: error: invalid suffix "n_disabletype__8" on integer constant > drivers/net/wireless/iwlwifi/iwl-drv.c:1196:1: error: expected identifier or '(' before numeric constant > drivers/net/wireless/iwlwifi/iwl-drv.c:1198:1: error: invalid suffix "n_disable__9" on integer constant > drivers/net/wireless/iwlwifi/iwl-drv.c:1198:1: error: expected identifier or '(' before numeric constant > drivers/net/wireless/iwlwifi/iwl-drv.c:1263:1: error: invalid suffix "ghz_disabletype__32" on integer constant > drivers/net/wireless/iwlwifi/iwl-drv.c:1263:1: error: expected identifier or '(' before numeric constant > drivers/net/wireless/iwlwifi/iwl-drv.c:1264:1: error: invalid suffix "ghz_disable__33" on integer constant > drivers/net/wireless/iwlwifi/iwl-drv.c:1264:1: error: expected identifier or '(' before numeric constant > drivers/net/wireless/iwlegacy/4965-mac.c:6825:1: error: invalid suffix "n_disabletype__11" on integer constant > drivers/net/wireless/iwlegacy/4965-mac.c:6825:1: error: expected identifier or '(' before numeric constant > drivers/net/wireless/iwlegacy/4965-mac.c:6826:1: error: invalid suffix "n_disable__12" on integer constant > drivers/net/wireless/iwlegacy/4965-mac.c:6826:1: error: expected identifier or '(' before numeric constant > > Presumably caused by commit 58876af0436e ("moduleparam: use __UNIQUE_ID > ()"). This commit removed the "__mod_" prefix that used to be added to > the front of the "name" passed to module_param_named(). Admittedly, the > documentation says that "name" must be "a valid C identifier which is the > parameter name", but the (ab)usage here used to work (the name starts > with a number). I prefer not to change module parameters name, since there are users who use current name in they modprobe config. Stanislaw